Skip to content

SGML support#4

Open
saturday06 wants to merge 2 commits into
jscheid:masterfrom
saturday06:sgml
Open

SGML support#4
saturday06 wants to merge 2 commits into
jscheid:masterfrom
saturday06:sgml

Conversation

@saturday06
Copy link
Copy Markdown
Contributor

No description provided.

@saturday06
Copy link
Copy Markdown
Contributor Author

Thank you for pointing that out. I fixed my misunderstood regexp. I would like to match the regexp with html or sgml comments like as much as possible. Please re-review it.

@jscheid
Copy link
Copy Markdown
Owner

jscheid commented Apr 15, 2013

Sorry I've let this one slip, I've been terribly busy with other things in the past few weeks.

This still looks fishy to me. If I'm not mistaken, it would match all of the following as comments even though they aren't:

<!x-- ... -->
<!-- ... --x>
<!-- ... --->
<!-- ... -- ... -->

The last one might be tricky (or impossible) to cover with the regexp mechanics currently offered by dtrt-indent, so I think it would be OK to ignore it for now. But the first three can be done no problem as far as I can tell.

See http://www.w3.org/TR/2008/REC-xml-20081126/#sec-comments

@rrthomas
Copy link
Copy Markdown
Collaborator

@jipodine, would you like to look at the outstanding issue on this pull request, and also rebase it?

@jipodine
Copy link
Copy Markdown
Contributor

Good catch, but no time for this until next week...

@jipodine
Copy link
Copy Markdown
Contributor

Quick try, before disappearing for a while. Untested, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants