-
Notifications
You must be signed in to change notification settings - Fork 123
Add C-API Capsule #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add C-API Capsule #961
Conversation
|
I'm going to try working on encoders today for a bit as well as planning out how users should subclass the encoder objects possibly using the C Structure and build around it as well as the writing in of bytes & bytearray types. |
|
It would be nice if you could provide some documentation on how to use this feature. I'm surely curious myself |
…r optionally compiling _testcapi (Should disable upon distribution)
@jacopoabramo I got around to making the |
|
I'm going to fix |
|
@jacopoabramo I added |
Warning
This pull request is a still a being worked on and is based off previous work I did for a different library based off #958
I have not added a whole lot yet in order to be sure that this is what other maintainers had in mind otherwise I will simply wait for input. It should be noted that this concept I had was based off unfinished work I had previously done for another library but works nevertheless.
Important
It should also be noted that getting this implemented will take time and planning on what the best approach would be to take and to do it all slow and steady. I have not implemented more objects besides Fields and Factories because I wanted to ensure that what gets added makes sense and is in the best interest of the maintainers in order to not make the process anymore stressful than it may already be to maintain.
Edit: Here is the objects I am planning to add to the C-API
Checklist
Field is named MsgspecFieldObjectinmsgspec.hso when someone compiles the code something Generic likeField(which could theoretically be used in a different C library or another Dev's implementation) it isn't being mixed and causing developers headaches and compilation issues.fixes #958