Ze/labvm status job

[WarriorAchilles]

Implemented service and job to check the status of vms every minute.

[jasekiw]

Add the following to the ServiceProvider.ProvideAppServices method:

 services.AddScoped<TestVmConnectionService>();

Then rewrite this section to handle the dependency injection:

Suggested change

	using var context = scope.ServiceProvider.GetService<DefaultContext>();
	// Do job
	var connectionService = new TestVmConnectionService(context);
	await connectionService.TestLabVmConnection();
	var connectionService = scope.ServiceProvider.GetService<TestVmConnectionService>();
	await connectionService.TestLabVmConnection();

Then anything in the constructor of the TestVmConnectionService will be automatically injected.

[jasekiw]

@WarriorAchilles
To make the code more testable and separate concerns, do the following:

Create an InjectedAsyncJob class.

using System;
using FluentScheduler;
using Microsoft.Extensions.DependencyInjection;

namespace CSLabs.Api.Jobs
{
    public class InjectedAsyncJob<T> : IJob where T : AsyncJob
    {
        private IServiceProvider _provider;

        public InjectedAsyncJob(IServiceProvider provider) => _provider = provider;

        public void Execute()
        {
            using var scope = _provider.CreateScope();
            scope.ServiceProvider.GetService<T>().Execute();
        }
    }
}

Change the VmStatusJob to the following:

using System.Threading.Tasks;
using CSLabs.Api.Services;

namespace CSLabs.Api.Jobs
{
    public class VmStatusJob : AsyncJob
    {
        private readonly TestVmConnectionService _service;
        public VmStatusJob(TestVmConnectionService service) =>
            _service = service;
        protected override async Task ExecuteAsync() => await _service.TestLabVmConnection();
    }
}

Change the schedule call to the following:

Schedule(provider.GetService<InjectedAsyncJob<VmStatusJob>>).ToRunEvery(1).Minutes();

Add this to the ServiceProvider:

services.AddTransient<VmStatusJob>();
services.AddTransient<InjectedAsyncJob<VmStatusJob>>();

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jasekiw]

You havent configured this ProxmoxDBApito be used anywhere but one place, it should be used instead of the Proxmox api since you want to track the start and stop states of the VM when initiated by the UI.

[jasekiw]

The vm id here is the proxmox vmid so the .Find(vmId) will fail.

[jasekiw]

The ses sender is merged, so you should be able to continue with this.