Skip to content

Ddm turing compat - #140

Merged
itsdfish merged 4 commits into
itsdfish:masterfrom
rsenne:ddm-turing-compat
Oct 11, 2026
Merged

itsdfish merged 4 commits into
itsdfish:masterfrom
rsenne:ddm-turing-compat

Conversation

@rsenne

@rsenne rsenne commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Fixes a docs issue

@rsenne

rsenne commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

This should be merged after #139 (if you decide to integrate it). Otherwise this will need to be cherry picked

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Benchmark Results

master 2576d95... master / 2576d95...
logpdf/("SequentialSamplingModels.DDM", 10) 1.38 ± 0.09 μs 1.38 ± 0.089 μs 1 ± 0.092
logpdf/("SequentialSamplingModels.DDM", 100) 13.5 ± 0.62 μs 13.5 ± 0.7 μs 1 ± 0.069
logpdf/("SequentialSamplingModels.LBA", 10) 2.34 ± 0.12 μs 2.36 ± 0.12 μs 0.99 ± 0.07
logpdf/("SequentialSamplingModels.LBA", 100) 18.1 ± 0.49 μs 18.1 ± 0.51 μs 1 ± 0.039
logpdf/("SequentialSamplingModels.LNR", 10) 1.33 ± 0.11 μs 1.33 ± 0.13 μs 1.01 ± 0.13
logpdf/("SequentialSamplingModels.LNR", 100) 7.33 ± 0.41 μs 7.24 ± 0.5 μs 1.01 ± 0.09
logpdf/("SequentialSamplingModels.RDM", 10) 2.1 ± 0.23 μs 2.08 ± 0.23 μs 1.01 ± 0.16
logpdf/("SequentialSamplingModels.RDM", 100) 18.7 ± 0.76 μs 18.7 ± 0.75 μs 1 ± 0.057
logpdf/("SequentialSamplingModels.Wald", 10) 1.07 ± 0.007 μs 1.06 ± 0.006 μs 1 ± 0.0087
logpdf/("SequentialSamplingModels.Wald", 100) 9.19 ± 0.18 μs 9.18 ± 0.19 μs 1 ± 0.028
rand/("SequentialSamplingModels.DDM", 10) 2.51 ± 0.32 μs 2.48 ± 0.29 μs 1.01 ± 0.18
rand/("SequentialSamplingModels.DDM", 100) 23.5 ± 1.1 μs 23.4 ± 1 μs 1.01 ± 0.066
rand/("SequentialSamplingModels.LBA", 10) 1.29 ± 0.055 μs 1.34 ± 0.068 μs 0.96 ± 0.064
rand/("SequentialSamplingModels.LBA", 100) 9.33 ± 0.88 μs 9.37 ± 0.64 μs 0.996 ± 0.12
rand/("SequentialSamplingModels.LCA", 10) 0.435 ± 0.14 ms 0.416 ± 0.15 ms 1.05 ± 0.51
rand/("SequentialSamplingModels.LCA", 100) 4.72 ± 0.13 ms 4.54 ± 0.099 ms 1.04 ± 0.036
rand/("SequentialSamplingModels.LNR", 10) 0.892 ± 0.04 μs 0.905 ± 0.037 μs 0.986 ± 0.06
rand/("SequentialSamplingModels.LNR", 100) 7.63 ± 3 μs 6.38 ± 2.9 μs 1.2 ± 0.72
rand/("SequentialSamplingModels.RDM", 10) 0.957 ± 0.04 μs 0.957 ± 0.042 μs 0.999 ± 0.061
rand/("SequentialSamplingModels.RDM", 100) 7.79 ± 0.26 μs 7.79 ± 0.22 μs 1 ± 0.043
rand/("SequentialSamplingModels.Wald", 10) 1.19 ± 0.031 μs 1.19 ± 0.031 μs 0.998 ± 0.037
rand/("SequentialSamplingModels.Wald", 100) 10.5 ± 0.13 μs 10.5 ± 0.13 μs 1 ± 0.018
simulate/SequentialSamplingModels.DDM 1.75 ± 0.45 μs 1.71 ± 0.44 μs 1.03 ± 0.37
simulate/SequentialSamplingModels.LBA 4.3 ± 2.6 μs 4.67 ± 2.2 μs 0.919 ± 0.7
simulate/SequentialSamplingModels.LCA 0.0599 ± 0.011 ms 0.0602 ± 0.012 ms 0.995 ± 0.27
simulate/SequentialSamplingModels.RDM 0.0491 ± 0.019 ms 0.0504 ± 0.018 ms 0.974 ± 0.51
simulate/SequentialSamplingModels.Wald 1.76 ± 0.45 μs 1.75 ± 0.44 μs 1.01 ± 0.36
simulate/mdft 0.131 ± 0.049 ms 0.127 ± 0.043 ms 1.03 ± 0.52
time_to_load 0.995 ± 0.0019 s 0.997 ± 0.0054 s 0.998 ± 0.0057

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@itsdfish

Copy link
Copy Markdown
Owner

@rsenne, there are some conflicts. Do you know which changes should be accepted?

@rsenne

rsenne commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

should be good now

@itsdfish
itsdfish merged commit e504256 into itsdfish:master Oct 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants