fix: Redirected Major Requirements to Other Block#386
Open
limlindsayj wants to merge 10 commits into
Open
Conversation
laggycomputer
requested changes
May 1, 2026
laggycomputer
requested changes
May 7, 2026
Member
laggycomputer
left a comment
laggycomputer
left a comment
There was a problem hiding this comment.
Code looks good, pending merge conflicts.
Upgrades biome.json to Biome v2 schema with root:true so indentStyle:space is respected, then reformats all files to revert accidental tab indentation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
laggycomputer
requested changes
May 20, 2026
laggycomputer
requested changes
May 20, 2026
Comment on lines
+153
to
+155
| if ("error" in json) { | ||
| return undefined; | ||
| } |
Member
There was a problem hiding this comment.
What's the reason for this? We already assert against the error variant in Zod on line 151.
laggycomputer
approved these changes
May 21, 2026
Member
laggycomputer
left a comment
laggycomputer
left a comment
There was a problem hiding this comment.
One unnecessary format change but that's fine.
Good work!
HwijungK
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the MAJOR block's requirements points to an OTHER block, that major's OTHER that contains the requirements get appended to the Major's json output. This happens in DegreeworksClient.ts. This Major json output gets put into Scraper.ts, which calls AuditParser.ts on that Major json output to parse it. If it contains "otherBlock", then it uses "otherBlock"'s rule array instead of the MAJOR block's rule array, since the requirements are stored there.
Related Issue
#321
Motivation and Context
Majors Classics, History, and English store their requirements in an OTHER block, atypical of how the other majors store their requirements directly in the MAJOR block. This causes the requirements of these majors to be missed when parsing the information for these majors.
How Has This Been Tested?
The degreeworks scraper was run and the database is now updated to have requirements for History and English. However, the Classics major is split into specializations, so the requirements are stored there.
Screenshots (if appropriate):
Types of changes
Checklist: