714/refactor-food-cards#743
Open
ShyamThangaraj wants to merge 1 commit into
Open
Conversation
…ry conflicts to PopularDishCard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
popular-dish-card.tsxandfood-card.tsxto remove duplicated modal/mutation logic by extracting it into a new sharedFoodCardShellcomponent. Also adds dietary restriction/preference conflict indicators to popular dish cards on the home screen, which previously only showed on restaurant page cards.Changes
food-card-shell.tsx(new) — shared wrapper that ownsisDesktop, open/close state,logMealMutation,handleAddToMealTracker, and theDialog/DrawerJSX. Uses a render prop (children) so each card passes in its own content while the shell handles the restfood-card.tsx— removed all duplicated modal/mutation logic, now wrapsFoodCardContentinFoodCardShellpopular-dish-card.tsx— same refactor as above; addedgetAllergies,getDietaryPreferences, andgetDietaryConflictsso conflicting dishes now show a red warning icon andopacity-70on the home screenTesting Instructions
/anteateryor/brandywineand click a food card — dialog (desktop) or drawer (mobile) should open as beforeCloses #714