Skip to content

Conversation

@pravinkedia
Copy link

@pravinkedia pravinkedia commented Dec 23, 2024

…b code to use the Granite 3.1 8b model

PR Checklist

Model Interaction

  • Flexible LLM platform support The platform should be easily switchable. Use LangChain or LlamaIndex.
  • Use prompt guide corresponding to the model For example for Granite 3.x Language Models

Data

  • Example data: Follow the example data guidance.

Notebook requirements

  • Notebook outputs cleared: Ensure all notebook outputs are cleared.
  • Automated testing: Add the recipe to the automated tests as described here
  • Test in Google Colab:
    • Test that it works in Google Colab (Python 3.10.12).
    • Colab has its own package set and Python version, so ensure compatibility.
  • Test locally:
    • Ensure the code works in a fresh Python virtual environment (venv).
  • Standard access to secrets and variables Include !pip install git+https://github.com/ibm-granite-community/utils in the first code cell in order to make get_env_var available to accessing secrets and variables in the recipe.

Incoming References

  • README.md updates:
    • Add a link to the recipe in the Table of Contents (ToC).
    • Include a Colab button after that link.

GitHub

  • Commits signed: All commits must be GPG or SSH signed.
  • DCO Compliance: Developer Certificate of Origin (DCO) applies to the code, documentation, and any example data provided. Ensure commits are signed off.

@pravinkedia pravinkedia enabled auto-merge (squash) December 30, 2024 05:13
@pravinkedia pravinkedia disabled auto-merge December 30, 2024 08:17
@pravinkedia pravinkedia enabled auto-merge (squash) December 30, 2024 08:17
@pravinkedia pravinkedia self-assigned this Dec 30, 2024
@deanwampler
Copy link
Contributor

Is it still the policy to clear the cell outputs?

@bjhargrave
Copy link
Member

bjhargrave commented Jan 7, 2025

Is it still the policy to clear the cell outputs?

Yes, one should run pre-commit before committing.

@pravinkedia
Copy link
Author

pls review and checkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants