Skip to content

Conversation

@rangeetpan
Copy link
Contributor

PR Checklist

  • Commits signed: All commits must be GPG or SSH signed.
  • DCO Compliance: Developer Certificate of Origin (DCO) applies to the code, documentation, and any example data provided. Ensure commits are signed off.
  • Notebook outputs cleared: Ensure all notebook outputs are cleared.
  • Automated testing: Add the recipe to the automated tests.
  • Test in Google Colab:
    • Test that it works in Google Colab (Python 3.10.12).
    • Colab has its own package set and Python version, so ensure compatibility.
  • Test locally:
    • Ensure the code works in a fresh Python virtual environment (venv).
  • Flexible LLM platform support:
    • The platform should be easily switchable. Use LangChain for now.
    • Include !pip install git+https://github.com/ibm-granite-community/granite-kitchen in the instructions.
  • Example data: Follow the example data guidance.
  • README.md updates:
    • Add a link to the recipe in the Table of Contents (ToC).
    • Include a Colab button after that link.

Copy link
Contributor

@deanwampler deanwampler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all three work in my ollama environment.

One remaining change you should make; the README says to start with summarize which is fine, but it's the last notebook, for translation, that installs ollama and pulls a model. These cells should be moved to the summarize notebook, IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants