added Code_Language_Translation notebook to convert code from one language to another
#126
Conversation
…anguage to another
rawkintrevo
left a comment
rawkintrevo
left a comment
There was a problem hiding this comment.
Thanks for the contribution @HitiIbm, could you please sign your DCO. I know i said it was just that one file, but I comitted an error, you also need to add the path in https://github.com/ibm-granite-community/granite-code-cookbook/blob/main/.github/notebook_lists/ollama_notebooks.txt also, I see in the line you added in the yaml file, an extra space after Code_Language_Translation, so please delete that.
Signed-off-by: Hiti Sinha <[email protected]>
|
Thanks for the review comments @rawkintrevo. I have updated, implementing the review comments along with signing-off while committing. |
|
@HitiIbm thanks so much- The DCO still doesn't appear to be signed, and please clear your outputs, but the ci-cd workflow add was well done, thank you! |
|
@rawkintrevo Thanks for the review comments. Hope, it appears to have the DCO appearing to be signed. Also, have cleared outputs and pushed again. |
|
Hi @HitiIbm , can you resolve the conflicts? (bc I can't). I'm going to hand this off to @bjhargrave for further review |
rawkintrevo
requested review from
bjhargrave
and removed request for
rawkintrevo
|
@rawkintrevo, Thanks for your message, and I've updated the same. |
bjhargrave
left a comment
bjhargrave
left a comment
There was a problem hiding this comment.
Please remove .DS_Store from the PR.
You may want to set that ignore in your global ignore file:
~ cat ~/.gitignore_global
*~
.DS_Store
Also, please add the notebook to the vanilla_notebooks.txt file.
| "load_dotenv()\n", | ||
| "\n", | ||
| "# Retrieve the API token directly from environment variables\n", | ||
| "replicate_api_token = os.getenv('REPLICATE_API_TOKEN')\n", |
There was a problem hiding this comment.
Please use get_env_var from utils repo.
3 participants
No description provided.