Skip to content

Feat - itemAnchorClick #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lofcz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat - itemAnchorClick #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Grid/Grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ var layoutId = 0;
* @param {String} [options.itemDraggingClass="muuri-item-dragging"]
* @param {String} [options.itemReleasingClass="muuri-item-releasing"]
* @param {String} [options.itemPlaceholderClass="muuri-item-placeholder"]
* @param {?function(Item, MouseEvent): (boolean|undefined)} [options.itemAnchorClick]
*/
function Grid(element, options) {
// Allow passing element as selector string
Expand Down Expand Up @@ -391,6 +392,11 @@ Grid.defaultOptions = {
itemDraggingClass: 'muuri-item-dragging',
itemReleasingClass: 'muuri-item-releasing',
itemPlaceholderClass: 'muuri-item-placeholder',
/**
* Optional callback for anchor (<a>) item clicks. If set, called with (item, event) when a click on an <a> item would trigger navigation. If it returns false or calls event.preventDefault(), navigation is prevented.
* @type {?function(Item, MouseEvent): (boolean|undefined)}
*/
itemAnchorClick: null,
};

/**
Expand Down
11 changes: 10 additions & 1 deletion src/Item/ItemDrag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,8 @@ ItemDrag.prototype._forceResolveStartPredicate = function (event) {
*/
ItemDrag.prototype._finishStartPredicate = function (event) {
var element = this._item._element;
var grid = this._item.getGrid();
var settings = grid._settings;

// Check if this is a click (very subjective heuristics).
var isClick = Math.abs(event.deltaX) < 2 && Math.abs(event.deltaY) < 2 && event.deltaTime < 200;
Expand All @@ -689,7 +691,14 @@ ItemDrag.prototype._finishStartPredicate = function (event) {

// If the gesture can be interpreted as click let's try to open the element's
// href url (if it is an anchor element).
if (isClick) openAnchorHref(element);
if (isClick) {
if (typeof settings.itemAnchorClick === 'function' && element.tagName.toLowerCase() === 'a') {
var clickEvent = event.srcEvent;
var result = settings.itemAnchorClick(this._item, clickEvent);
if (result === false || (clickEvent && clickEvent.defaultPrevented)) return;
}
openAnchorHref(element);
}
};

/**
Expand Down