Skip to content

Error in list() method description In services classes #219

Description

@DarkSide666

In service classes there is list() method description, like this one https://github.com/gocardless/gocardless-pro-php/blob/master/lib/Services/CreditorsService.php#L21

But it's wrong, as it always requires array parameter.

Instead of
@method ListResponse list(array $params)
it should be
@method ListResponse list(?array $params) or @method ListResponse list(array $params = []) (not sure how it's more correct)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions