Skip to content

Conversation

@yaananth
Copy link
Contributor

@yaananth yaananth commented Sep 5, 2025

Fabric eventhouse is just a kusto engine under the hood.

The changes here allows schematools to work with fabric eventhouse as well

Copilot AI review requested due to automatic review settings September 5, 2025 15:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Microsoft Fabric Eventhouse by extending the ToKustoClusterUrl method to handle Fabric cluster URLs with the .fabric.microsoft.com domain pattern.

  • Enhanced URL handling logic to detect and properly format Fabric cluster URLs
  • Improved null/empty string handling with explicit guard clauses
  • Added comprehensive test coverage for both traditional Kusto and new Fabric URL patterns

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
KustoSchemaTools/Parser/KustoExtensions.cs Updated ToKustoClusterUrl method to support Fabric URLs and improved input validation
KustoSchemaTools.Tests/Parser/KustoExtensionsTests.cs Added comprehensive test cases covering Fabric URLs and edge cases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sdseaton sdseaton merged commit 793d8bd into github:main Sep 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants