Test-drive Tour 8

[damithc]

Similar to #154
Tour available at https://git-mastery.org/lessons/trail/remoteBranches/

[damithc]

@jiaxinnns @desmondwong1215 @SAN-MUYUN Can help to test Tour 8 before I announce it to students?

[jiaxinnns]

Test Summary

T8L1

hp-remote-branch-push

LGTM

glossary-branch-push

LGTM

T8L2

hp-remote-branch-pull

1. From my understanding, using git switch track-sales will automatically set up track-sales branch to track origin/track-sales without having to use git switch -c track-sales origin/track-sales. However the given command still works and can be kept for completeness sake.

glossary-branch-pull

1. Download starts at DEF branch, would it be better to start at main branch for consistency across the exercises?

T8L3

hp-remote-branch-delete

LGTM

glossary-branch-delete

LGTM

T8L4

hp-remote-branch-rename

1. {% in text box might be unintended

glossary-branch-rename

LGTM

[desmondwong1215]

• OS: Windows11 + git bash, Ubuntu
• Git CLI is used

T8L1

glossary-branch-push

I agree that we can let students start at the main branch after the download script is run. I suggest letting students start at the main branch as well in this exercise.

T8L2

glossary-branch-pull

Similar to the issue of glossary-branch-push, we can let students start at the main branch in this exercise.

T8L3

hp-remote-branch-delete

The forked repo name should be 'gitmastery-samplerepo-books' instead of 'samplerepo-books'.

T8L4

glossary-branch-rename

Instead of renaming, I try to create a branch S-to-Z from the main branch, push it to the remote. I also deleted the local and remote branch STU.

git switch -c S-to-Z
git push origin S-to-Z
git branch -D STU
git push origin :STU

The verify logic failed to catch this.
I suggest improving the logic by searching for messages like Branch: renamed refs/heads/STU to refs/heads/S-to-Z in the reflog.

[damithc]

Thanks @jiaxinnns @desmondwong1215 for test-driving T8 💯

hp-remote-branch-pull

1. From my understanding, using git switch track-sales will automatically set up track-sales branch to track origin/track-sales without having to use git switch -c track-sales origin/track-sales. However the given command still works and can be kept for completeness sake.

Good point. Will look into this and update the text accordingly.

glossary-branch-pull

1. Download starts at DEF branch, would it be better to start at main branch for consistency across the exercises?

I agree. I'll leave this to you all to fix.

glossary-branch-rename

Instead of renaming, I try to create a branch S-to-Z from the main branch, push it to the remote. I also deleted the local and remote branch STU.

git switch -c S-to-Z
git push origin S-to-Z
git branch -D STU
git push origin :STU

The verify logic failed to catch this. I suggest improving the logic by searching for messages like Branch: renamed refs/heads/STU to refs/heads/S-to-Z in the reflog.

Good catch. This too, I'll leave to the team to resolve.

hp-remote-branch-rename

1. {% in text box might be unintended

###

Fixed.

hp-remote-branch-delete

The forked repo name should be 'gitmastery-samplerepo-books' instead of 'samplerepo-books'.

Fixed.

[SAN-MUYUN]

OS: Windows + Git Bash
Git UI: CLI

T8L1:

The verify logic works as expected. The instruction of the exercises suggest the students to push it to remote. In the set up itself, both origin, which points to the student's github repo, as well as the upstream, which pionts to the forked repo from gitmastery, are both present. Even though students do not have permission to push to this upstream repo, this could still lead to some confusion among students. It might be good if we can remove this upstream repo when setting up the exercise.

There also seem to have inconsistency in the origin and upstream url, especially when protocol is configured to ssh. When setting up, we can choose not to specify the url as https when calling clone_repo_with_gh, the github cli will automatically set the right url for us.

T8L2:

Apart from the starting branch for the exercise that is discussed above, the rest LGTM!

T8L3:

Verify logic is working good. Similar comment as T8L1 regarding the upstream.

T8L4:

Like mentioned above, for glossary-branch-rename, when the old branch is deleted, instead of rename, the verify logic fails to check this. It is still marked as completed even though the commits on the branch is lost.

[desmondwong1215]

I can help to improve the verify logic of glossary-branch-rename.

[SAN-MUYUN]

@desmondwong1215 issue created and assigned

[jiaxinnns]

I've fixed the issue of inconsistent starting branches: #264