Skip to content

Commit a855efe

Browse files
ref(openai-agents): Stop setting gen_ai.request.available_tools on Invoke Agent spans (#6955)
The attribute is not well-defined for agents as different tools can be available in an agent's lifetime.
1 parent 2e15294 commit a855efe

2 files changed

Lines changed: 0 additions & 27 deletions

File tree

sentry_sdk/integrations/openai_agents/spans/invoke_agent.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ def invoke_agent_span(
3838
SPANDATA.GEN_AI_OPERATION_NAME: "invoke_agent",
3939
},
4040
)
41-
42-
set_on_span = span.set_attribute
4341
else:
4442
start_span_function = get_start_span_function()
4543
span = start_span_function(
@@ -51,8 +49,6 @@ def invoke_agent_span(
5149

5250
span.set_data(SPANDATA.GEN_AI_OPERATION_NAME, "invoke_agent")
5351

54-
set_on_span = span.set_data
55-
5652
if should_send_default_pii():
5753
messages = []
5854
if agent.instructions:
@@ -101,12 +97,6 @@ def invoke_agent_span(
10197

10298
_set_agent_data(span, agent)
10399

104-
if len(agent.tools) > 0:
105-
set_on_span(
106-
SPANDATA.GEN_AI_REQUEST_AVAILABLE_TOOLS,
107-
safe_serialize([vars(tool) for tool in agent.tools]),
108-
)
109-
110100
return span
111101

112102

tests/integrations/openai_agents/test_openai_agents.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1998,12 +1998,6 @@ def simple_test_tool(message: str) -> str:
19981998
assert agent_span["attributes"]["gen_ai.agent.name"] == "test_agent"
19991999
assert agent_span["attributes"]["gen_ai.operation.name"] == "invoke_agent"
20002000

2001-
agent_span_available_tool = json.loads(
2002-
agent_span["attributes"]["gen_ai.request.available_tools"]
2003-
)[0]
2004-
2005-
assert all(agent_span_available_tool[k] == v for k, v in available_tool.items())
2006-
20072001
assert agent_span["attributes"]["gen_ai.request.max_tokens"] == 100
20082002
assert agent_span["attributes"]["gen_ai.request.model"] == "gpt-4"
20092003
assert agent_span["attributes"]["gen_ai.request.temperature"] == 0.7
@@ -2224,12 +2218,6 @@ def simple_test_tool(message: str) -> str:
22242218
assert agent_span["attributes"]["gen_ai.agent.name"] == "test_agent"
22252219
assert agent_span["attributes"]["gen_ai.operation.name"] == "invoke_agent"
22262220

2227-
agent_span_available_tool = json.loads(
2228-
agent_span["attributes"]["gen_ai.request.available_tools"]
2229-
)[0]
2230-
2231-
assert all(agent_span_available_tool[k] == v for k, v in available_tool.items())
2232-
22332221
assert agent_span["attributes"]["gen_ai.request.max_tokens"] == 100
22342222
assert agent_span["attributes"]["gen_ai.request.model"] == "gpt-4"
22352223
assert agent_span["attributes"]["gen_ai.request.temperature"] == 0.7
@@ -2444,11 +2432,6 @@ def simple_test_tool(message: str) -> str:
24442432
assert agent_span["data"]["gen_ai.agent.name"] == "test_agent"
24452433
assert agent_span["data"]["gen_ai.operation.name"] == "invoke_agent"
24462434

2447-
agent_span_available_tool = json.loads(
2448-
agent_span["data"]["gen_ai.request.available_tools"]
2449-
)[0]
2450-
assert all(agent_span_available_tool[k] == v for k, v in available_tool.items())
2451-
24522435
assert agent_span["data"]["gen_ai.request.max_tokens"] == 100
24532436
assert agent_span["data"]["gen_ai.request.model"] == "gpt-4"
24542437
assert agent_span["data"]["gen_ai.request.temperature"] == 0.7

0 commit comments

Comments
 (0)