Skip to content

Commit bd33f26

Browse files
committed
fixup! chore: Declare workspace packages where they are imported
1 parent 25828c5 commit bd33f26

2 files changed

Lines changed: 1 addition & 17 deletions

File tree

‎docs/new-sdk-release-checklist.md‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ differ slightly for other SDKs depending on how they are structured and how they
1212
- [ ] The package has a working unit testing environment
1313
- [ ] The package builds correctly (inspect `<package>/build` directory)
1414
- [ ] The package is in the `packages` list of `pnpm-workspace.yaml` and in the `workspaces` list of the root
15-
`package.json` (in the same order), and it is in the root `devDependencies` with the version `workspace:*`.
16-
`scripts/verify-packages-versions.js` checks this.
15+
`package.json` (in the same order). `scripts/verify-packages-versions.js` checks this.
1716

1817
- [ ] Make sure that the `README.md` content is up to date and contains at least:
1918
- [ ] The correct name + a brief description of the SDK

‎scripts/verify-packages-versions.js‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -59,19 +59,4 @@ must contain the same packages in the same order.
5959
process.exit(1);
6060
}
6161

62-
// Configs import workspace packages that they do not declare, so every workspace package must be linked into the
63-
// root node_modules folder, as Yarn did.
64-
const missingRootDevDependencies = pkg.workspaces
65-
.map(workspace => require(path.join(__dirname, '..', workspace, 'package.json')).name)
66-
.filter(name => pkg.devDependencies[name] !== 'workspace:*');
67-
68-
if (missingRootDevDependencies.length > 0) {
69-
console.error(`
70-
[MISSING ROOT DEV DEPENDENCIES]: Every workspace package must be in the \`devDependencies\` of the root package.json
71-
with the version \`workspace:*\`. Missing:
72-
${missingRootDevDependencies.join('\n')}
73-
`);
74-
process.exit(1);
75-
}
76-
7762
process.exit(0);

0 commit comments

Comments
 (0)