Skip to content

Commit 47728a4

Browse files
committed
chore: Update comments related to span links with latest info
1 parent 96b56c5 commit 47728a4

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎packages/browser/src/tracing/linkedTraces.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,8 +191,8 @@ export function addPreviousTraceSpanLink(
191191
},
192192
});
193193

194-
// TODO(v12): Remove this once the Sentry trace view finds linked traces via span links. EAP stores
195-
// span links, but the trace view still reads this attribute to navigate to the previous/next trace.
194+
// TODO(v12): Remove once EAP can filter span links by type. The Sentry trace view searches this attribute to find the NEXT trace.
195+
// Sentry 26.9 and older also read it to find the PREVIOUS trace. Newer versions read the span link.
196196
span.setAttribute(
197197
PREVIOUS_TRACE_TMP_SPAN_ATTRIBUTE,
198198
`${previousTraceSpanCtx.traceId}-${previousTraceSpanCtx.spanId}-${

‎packages/cloudflare/src/wrapMethodWithSentry.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,9 +217,9 @@ export function wrapMethodWithSentry<T extends OriginalMethod>(
217217

218218
if (storedContext) {
219219
span.addLinks(buildSpanLinks(storedContext));
220-
// TODO(v12): Remove this once the Sentry trace view finds linked traces via span links.
221-
// EAP stores span links, but the trace view still reads this attribute to navigate to the
222-
// previous/next trace.
220+
221+
// TODO(v12): Remove once EAP can filter span links by type. The Sentry trace view searches this attribute to find the NEXT trace.
222+
// Sentry 26.9 and older also read it to find the PREVIOUS trace. Newer versions read the span link.
223223
const sampledFlag = storedContext.sampled ? '1' : '0';
224224
span.setAttribute(
225225
'sentry.previous_trace',

0 commit comments

Comments
 (0)