Skip to content

Add NFG games to catalog from Nau2004 and format NFG games in catalog page#874

Merged
edwardchalstrey1 merged 21 commits into
masterfrom
add-example-nfg-catalog
May 20, 2026
Merged

Add NFG games to catalog from Nau2004 and format NFG games in catalog page#874
edwardchalstrey1 merged 21 commits into
masterfrom
add-example-nfg-catalog

Conversation

@edwardchalstrey1

@edwardchalstrey1 edwardchalstrey1 commented May 18, 2026

Copy link
Copy Markdown
Member

TODO

  • Make EFG/NFG in same table (or if not, add Download header above NFG download)
  • Game could probably use a better name and title - some of what's in the title now moved to description
  • Merge main
  • Add appropriate download links
  • Update draw_tree version to 0.9.0
  • Consolidate draw_tree usage in efg vs nfg in update.py
  • Add player labels to games

Changes

  • Adds game(s) from this paper
  • Adds support for running code on the catalog page via jupyter_sphinx
  • Unifies the catalog update script and rst table to make EFG and NFG games in the catalog look the same in the table, both rendered with Latex
  • Updates draw_tree version in gambit docs to 0.9
  • Adds SVG downloads to the catalog which were missing

Description of the changes in this PR

This PR adds 4 new games to the nau2004 folder in the catalog and changes how the catalog update script works to handle normal form games.

How to review this PR

View the docs catalog page: https://gambitproject--874.org.readthedocs.build/en/874/catalog.html#catalog

@tturocy

tturocy commented May 18, 2026

Copy link
Copy Markdown
Member

@edwardchalstrey1 Ping me on this when it's getting closer to ready. I'd like to ensure we've added all the games and can give them appropriate description text. This will be an interesting case because the games aren't actually given figure or table labels in the article!

@edwardchalstrey1

edwardchalstrey1 commented May 18, 2026

Copy link
Copy Markdown
Member Author

@tturocy ok so these games would be as follows from the paper, I can have a go at adding an NFG for each with a suitable title, slug and description derived from the paper

Battle of sexes (page 5)

Screenshot 2026-05-18 at 16 00 13

A THREE-PLAYER GAME WITH A UNIQUE NASH SOLUTION IN IRRATIONAL STRATEGIES (page 7)

Screenshot 2026-05-18 at 16 04 38

A GAME WITH A CONTINUUM OF COMPLETELY MIXED-STRATEGY NASH EQUILIBRIA (page 9)

Screenshot 2026-05-18 at 16 01 09

2x2x4 game (page 11)

Screenshot 2026-05-18 at 16 01 47

@edwardchalstrey1 edwardchalstrey1 changed the title Add first NFG example to catalog Add first NFG examples to catalog from Nau2004 May 19, 2026
@edwardchalstrey1 edwardchalstrey1 marked this pull request as ready for review May 19, 2026 12:06
@edwardchalstrey1

Copy link
Copy Markdown
Member Author

Hi @tturocy @rahulsavani take a look at the catalog page from "Battle of the sexes" downwards - you'll see 4 new games from the paper. I suggest to review and edit the included descriptions, titles and filenames (which I instructed Claude to use the paper itself to generate). The filenames in the absence of figure names are named by sections, which you may also want to change.

Also to note a slight difference in how I handle EFG vs NFG in the catalog docs table, for EFG the code is just printed (in #829 the images from DrawTree are also included), whereas for NFG games the catalog code actually gets run in order to generate the html output (this will also look a little different if we merge #834) - so another question is whether you think the html tables look good enough here on the catalog page, or whether I should try to get a nicer Latex version rendered based on a call to g.to_latex().

@edwardchalstrey1 edwardchalstrey1 marked this pull request as draft May 19, 2026 14:58
@edwardchalstrey1 edwardchalstrey1 marked this pull request as ready for review May 20, 2026 14:07
@edwardchalstrey1

Copy link
Copy Markdown
Member Author

As per discussion yesterday I will go ahead and merge this

@edwardchalstrey1 edwardchalstrey1 changed the title Add first NFG examples to catalog from Nau2004 Add NFG games to catalog from Nau2004 and format NFG games in catalog page May 20, 2026
@edwardchalstrey1 edwardchalstrey1 merged commit 3a8d59f into master May 20, 2026
26 checks passed
@edwardchalstrey1 edwardchalstrey1 deleted the add-example-nfg-catalog branch May 20, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants