-
Beta Was this translation helpful? Give feedback.
Replies: 6 comments 2 replies
-
Beta Was this translation helpful? Give feedback.
-
|
After re-reading my response I realize I left the last bit as an exercise for the reader. I'll finish the connection. I think these are different types of statements:
Note that the concept of liftover incorporates elements of algorithm, parameter, and build, so that defining a set that includes liftover as a criterion might require representation of those elements in either VA statements or CatVRS constraints (which would probably need VA statements underlying them anyway). Back to what I think is your primary question:
This is a policy question. The data can be represented several ways, and which representation is the most appropriate will depend on the use case. For example, submitters could use statements 0 and/or 2. Looking through a list of clinvar variations on build 38, statement 5 might be more natural. Statement 5 can be used as a seed to create the generalized statement 4. This approach supports the type of generalization that I think is desired but does not introduce assertions that go beyond the original submissions. So in my mind, it is not a matter of choosing 1 thing - it's supporting all of the above and then using whichever is most appropriate to convey the desired semantics. |
Beta Was this translation helpful? Give feedback.
-
|
Cat-VRS doesn't care about your ClinVar variant IDs or how you map and retain submissions to them! If you need or want, you can define canonical build 37 variants AND canonical build 38 variants. And you can map them to one another. Go crazy! |
Beta Was this translation helpful? Give feedback.
-
|
I also disagree that we need or even should have consistent policies across datasets here. Cat-VRS doesn't do matching, it just shows you what matching exists. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you Larry for fostering such a wonderful discussion. Broadly I agree with the above comments from Bob and Catherine, that this is ultimately a policy decision for ClinVar to decide of what they/you want to define as the CanonicalAllele. But, a couple of thoughts:
|
Beta Was this translation helpful? Give feedback.
-
|
As we talked about on Slack, I am going to close this Discussion per having the author of the canonical allele pick the defining allele, but please open it at any time! I'd also love to see how you implemented this. |
Beta Was this translation helpful? Give feedback.




I agree 100%.
But, my task is to try to standardize clinvar without "redefining" it. So, I need to determine what they are actually doing so my canonical build 37 vs 38 variants map to their ids in a computationally consistent way. But I think this is possible as long as I document how I dealt with some of these "special" cases.