Provide haptic feedback without delay

Author: LaurentTreguier

app/src/legacy/kotlin/app/fyreplace/fyreplace/legacy/extensions/ViewExt.kt

@@ -1,6 +1,8 @@
 package app.fyreplace.fyreplace.legacy.extensions
 
 import android.content.Context
+import android.os.Build
+import android.view.HapticFeedbackConstants
 import android.view.View
 import android.view.inputmethod.InputMethodManager
 import androidx.core.graphics.Insets
@@ -38,3 +40,29 @@ fun View.hideSoftInput() {
     context.getSystemService(InputMethodManager::class.java)
         ?.hideSoftInputFromWindow(windowToken, 0)
 }
+
+fun View.provideHapticFeedback(type: HapticType = HapticType.SIMPLE) {
+    performHapticFeedback(
+        when {
+            Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE -> when (type) {
+                HapticType.TOGGLE_ON -> HapticFeedbackConstants.TOGGLE_ON
+                HapticType.TOGGLE_OFF -> HapticFeedbackConstants.TOGGLE_OFF
+                else -> HapticFeedbackConstants.CONFIRM
+            }
+
+            Build.VERSION.SDK_INT >= Build.VERSION_CODES.R -> HapticFeedbackConstants.CONFIRM
+            else -> HapticFeedbackConstants.VIRTUAL_KEY
+        }
+    )
+}
+
+fun View.provideHapticFeedback(positive: Boolean) = provideHapticFeedback(
+    if (positive) HapticType.TOGGLE_ON
+    else HapticType.TOGGLE_OFF
+)
+
+enum class HapticType {
+    TOGGLE_ON,
+    TOGGLE_OFF,
+    SIMPLE
+}

app/src/legacy/kotlin/app/fyreplace/fyreplace/legacy/ui/BasePresenter.kt

@@ -1,9 +1,9 @@
 package app.fyreplace.fyreplace.legacy.ui
 
-import android.os.Build
-import android.view.HapticFeedbackConstants
 import android.view.View
 import androidx.annotation.StringRes
+import app.fyreplace.fyreplace.legacy.extensions.HapticType
+import app.fyreplace.fyreplace.legacy.extensions.provideHapticFeedback
 import com.google.android.material.snackbar.BaseTransientBottomBar
 import com.google.android.material.snackbar.Snackbar
 
@@ -22,30 +22,4 @@ interface BasePresenter : ContextHolder {
             rootView.provideHapticFeedback(haptics)
         }
     }
-
-    fun View.provideHapticFeedback(type: HapticType = HapticType.SIMPLE) {
-        performHapticFeedback(
-            when {
-                Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE -> when (type) {
-                    HapticType.TOGGLE_ON -> HapticFeedbackConstants.TOGGLE_ON
-                    HapticType.TOGGLE_OFF -> HapticFeedbackConstants.TOGGLE_OFF
-                    else -> HapticFeedbackConstants.CONFIRM
-                }
-
-                Build.VERSION.SDK_INT >= Build.VERSION_CODES.R -> HapticFeedbackConstants.CONFIRM
-                else -> HapticFeedbackConstants.VIRTUAL_KEY
-            }
-        )
-    }
-
-    fun View.provideHapticFeedback(positive: Boolean) = provideHapticFeedback(
-        if (positive) HapticType.TOGGLE_ON
-        else HapticType.TOGGLE_OFF
-    )
-
-    enum class HapticType {
-        TOGGLE_ON,
-        TOGGLE_OFF,
-        SIMPLE
-    }
 }

app/src/legacy/kotlin/app/fyreplace/fyreplace/legacy/ui/adapters/FeedAdapter.kt

@@ -12,6 +12,7 @@ import app.fyreplace.fyreplace.databinding.ItemFeedPostTextBinding
 import app.fyreplace.fyreplace.legacy.events.EventsManager
 import app.fyreplace.fyreplace.legacy.events.RemoteNotificationWasReceivedEvent
 import app.fyreplace.fyreplace.legacy.extensions.firstChapter
+import app.fyreplace.fyreplace.legacy.extensions.provideHapticFeedback
 import app.fyreplace.fyreplace.legacy.ui.adapters.holders.PreviewHolder
 import app.fyreplace.protos.Post
 import kotlinx.coroutines.MainScope
@@ -115,6 +116,8 @@ class FeedAdapter(
         fun onUpClicked(view: View) = vote(view)
 
         private fun vote(button: View) {
+            button.provideHapticFeedback(positive = button == up)
+
             if (!isVoting) scope.launch {
                 button.isActivated = true
                 delay(500)

app/src/legacy/kotlin/app/fyreplace/fyreplace/legacy/ui/fragments/FeedFragment.kt

@@ -91,10 +91,7 @@ class FeedFragment :
     }
 
     override fun onPostVoted(view: View, position: Int, spread: Boolean) {
-        view.provideHapticFeedback(positive = spread)
-        launch {
-            vm.vote(position, spread)
-        }
+        launch { vm.vote(position, spread) }
     }
 
     override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {