Skip to content

Commit 6217255

Browse files
authored
Declare missing direct dependencies (#303)
The package imports `frequenz.client.common`, `frequenz.core` and `grpc` directly, but none of them was declared in `pyproject.toml`; they were only pulled in transitively through `frequenz-client-dispatch`. If that client changed its own requirements (for example to accept `frequenz-client-common` v0.4.x), this library could break without any warning from the resolver. This declares all three explicitly. The version ranges follow what the minimum supported `frequenz-client-dispatch` (0.11.3) requires, with `frequenz-client-common` at `>= 0.3.8, < 0.4.0` as suggested in the issue, so the constraints stay consistent with the dispatch client. The `grpcio` floor is 1.80.0 because `frequenz-client-common` 0.3.8 needs `frequenz-api-common >= 0.8.4`, which itself requires `grpcio >= 1.80`. Fixes #302.
2 parents 69aa0f5 + b24ff6b commit 6217255

2 files changed

Lines changed: 5 additions & 17 deletions

File tree

‎RELEASE_NOTES.md‎

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,10 @@
11
# Dispatch Highlevel Interface Release Notes
22

3-
## Summary
4-
5-
<!-- Here goes a general summary of what this release is about -->
6-
7-
## Upgrading
8-
9-
<!-- Here goes notes on how to upgrade from previous versions, including deprecations and what they should be replaced with -->
10-
11-
## New Features
12-
13-
<!-- Here goes the main new features and examples or instructions on how to use them -->
14-
153
## Enhancements
164

175
- Improved docstring documentation across the project.
186

197
## Bug Fixes
208

21-
<!-- Here goes notable bug fixes that are worth a special mention or explanation -->
22-
23-
* Fixed documentation cross-references to dependencies by updating the
24-
mkdocstrings inventories to match the minimum dependency versions and
25-
adding the missing `frequenz-client-base` inventory.
9+
* Fixed documentation cross-references to dependencies by updating the mkdocstrings inventories to match the minimum dependency versions and adding the missing `frequenz-client-base` inventory.
10+
* Declared the missing direct dependencies `frequenz-client-common`, `frequenz-core` and `grpcio`, which were previously only pulled in indirectly through `frequenz-client-dispatch`.

‎pyproject.toml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ dependencies = [
4242
"frequenz-channels >= 1.6.1, < 2.0.0",
4343
"frequenz-client-dispatch >= 0.11.3, < 2.0.0",
4444
"frequenz-client-base >= 0.11.0, < 0.12.0",
45+
"frequenz-client-common >= 0.3.8, < 0.4.0",
46+
"frequenz-core >= 1.0.2, < 2.0.0",
47+
"grpcio >= 1.80.0, < 2.0.0",
4548
]
4649
dynamic = ["version"]
4750

0 commit comments

Comments
 (0)