Skip to content

Chart name change should trigger upgrade, not uninstall/reinstall #1450

@mattnewell

Description

@mattnewell

Goooood afternoon, flux friends! I've been struggling with a thing ...

When the chart name referenced by a HelmRelease changes (e.g. switching from old-bad-name to nice-clean-name), the controller treats this as a release target change and performs a full uninstall followed by a fresh install. This causes downtime as all resources managed by the release are deleted and recreated. We shoot for zero downtime, and this prevents me from doing what I consider basic housekeeping.

In my use case, I'm imagining zero change to the rendered manifest -- identical chart, just new name. But even if there were changes, wouldn't the normal helm upgrade already handle the case where templates are added or removed between the old and new chart? Why do a full delete/recreate cycle?

I'd be happy to submit a PR for this, and naively delete these two lines. However, this was clearly intentional, and I assume there must be downstream negative impacts that aren't obvious to me?

Or is there another way around this? Either way, thanks in advance,
-- m.

P.S. -- the somewhat analogous operation for renaming kustomizations is possible.

P.P.S -- i went ahead and created a PR anyways, though I have zero expectation that it is accepted as-is.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions