From d8f600662ba37f37780a9075253b715840469351 Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Tue, 14 Apr 2026 11:51:28 -0400 Subject: [PATCH 1/3] Warn that link checking is for markdown links only --- tool/dart_skills_lint/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/tool/dart_skills_lint/README.md b/tool/dart_skills_lint/README.md index 1d27af89..e773faaf 100644 --- a/tool/dart_skills_lint/README.md +++ b/tool/dart_skills_lint/README.md @@ -193,6 +193,7 @@ The linter checks against the criteria defined in `documentation/knowledge/SPECI ### 4. Content Constraints - **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.30/#hard-line-breaks). +- **Path Integrity**: Checks that relative and absolute paths referenced within Markdown links in `SKILL.md` point to valid, existing files. ## Contributing From 28bf11df9bbde0b69ade208349e476564a74456b Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Tue, 14 Apr 2026 12:03:59 -0400 Subject: [PATCH 2/3] Code review feedback --- tool/dart_skills_lint/README.md | 4 ++-- .../dart_skills_lint/documentation/knowledge/SPECIFICATION.md | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tool/dart_skills_lint/README.md b/tool/dart_skills_lint/README.md index e773faaf..0559c0ab 100644 --- a/tool/dart_skills_lint/README.md +++ b/tool/dart_skills_lint/README.md @@ -192,8 +192,8 @@ The linter checks against the criteria defined in `documentation/knowledge/SPECI - **Compatibility (`compatibility`)**: Max 500 characters. ### 4. Content Constraints -- **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.30/#hard-line-breaks). -- **Path Integrity**: Checks that relative and absolute paths referenced within Markdown links in `SKILL.md` point to valid, existing files. +- **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.31.2/#hard-line-breaks). +- **Path Constraints**: Checks that Markdown links do not use absolute paths to enforce portability. Can optionally be configured to check that relative paths point to valid, existing files (disabled by default). ## Contributing diff --git a/tool/dart_skills_lint/documentation/knowledge/SPECIFICATION.md b/tool/dart_skills_lint/documentation/knowledge/SPECIFICATION.md index 189c7744..de597fe4 100644 --- a/tool/dart_skills_lint/documentation/knowledge/SPECIFICATION.md +++ b/tool/dart_skills_lint/documentation/knowledge/SPECIFICATION.md @@ -63,6 +63,7 @@ Validation ensures that a skill directory and its `SKILL.md` file adhere to the #### 4.1.4 Content Constraints - **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.30/#hard-line-breaks). +- **Path Constraints**: Markdown links must not use absolute paths to enforce portability. Can optionally be configured to check that relative paths point to valid, existing files (disabled by default). ### 5.2 Scripts & Tools - Scripts in the `scripts/` directory should be self-documenting and provide clear error messages. From 25dfd3cbc4b52e79c4cbd486f269985332b208d4 Mon Sep 17 00:00:00 2001 From: Reid Baker Date: Tue, 14 Apr 2026 15:17:46 -0400 Subject: [PATCH 3/3] Code review feedback --- tool/dart_skills_lint/README.md | 2 +- .../dart_skills_lint/documentation/knowledge/SPECIFICATION.md | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tool/dart_skills_lint/README.md b/tool/dart_skills_lint/README.md index 0559c0ab..0cf78675 100644 --- a/tool/dart_skills_lint/README.md +++ b/tool/dart_skills_lint/README.md @@ -193,7 +193,7 @@ The linter checks against the criteria defined in `documentation/knowledge/SPECI ### 4. Content Constraints - **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.31.2/#hard-line-breaks). -- **Path Constraints**: Checks that Markdown links do not use absolute paths to enforce portability. Can optionally be configured to check that relative paths point to valid, existing files (disabled by default). +- **Path Constraints**: Checks that **inline** Markdown links do not use absolute paths to enforce portability. Can optionally be configured to check that relative paths point to valid, existing files (disabled by default). *Note: This rule only supports inline Markdown links and does not detect HTML or reference-style links.* ## Contributing diff --git a/tool/dart_skills_lint/documentation/knowledge/SPECIFICATION.md b/tool/dart_skills_lint/documentation/knowledge/SPECIFICATION.md index de597fe4..b48f23cf 100644 --- a/tool/dart_skills_lint/documentation/knowledge/SPECIFICATION.md +++ b/tool/dart_skills_lint/documentation/knowledge/SPECIFICATION.md @@ -62,8 +62,8 @@ Validation ensures that a skill directory and its `SKILL.md` file adhere to the - Length: Maximum 500 characters. #### 4.1.4 Content Constraints -- **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.30/#hard-line-breaks). -- **Path Constraints**: Markdown links must not use absolute paths to enforce portability. Can optionally be configured to check that relative paths point to valid, existing files (disabled by default). +- **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.31.2/#hard-line-breaks). +- **Path Constraints**: **Inline** Markdown links must not use absolute paths to enforce portability. Can optionally be configured to check that relative paths point to valid, existing files (disabled by default). *Note: Validation only applies to inline Markdown links; HTML and reference-style links are not supported.* ### 5.2 Scripts & Tools - Scripts in the `scripts/` directory should be self-documenting and provide clear error messages.