Repository navigation
Fix onboarding blockers from signup to first event - #2735
Merged
Merged
Conversation
Marking a project configured after its first event used an id-only patch. That notification carries no organization id, so the web socket broker dropped it and onboarding prompts stayed stale until a manual refresh. Publish the change with the project's organization while still patching only is_configured, and make it searchable before clients refetch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The verify page posted to a route that does not exist, so every emailed verification link failed. Call the GET endpoint with the token as an encoded path segment, explain missing, invalid, used, and expired links, and refresh the current user so the "Email not verified" prompt clears. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The add project form now submits with "Continue to Client Setup". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Free organizations with no projects saw the free plan upsell instead of the prompt to add a first project. Order organization notices so account problems come first, then setup steps, then upgrade prompts. Also fix the "Set up" wording and keep only one playful line across the setup notices. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every 401 from login or signup showed "Invalid email or password", including rate-limit denials. Use the existing problem titles to tell users when they need to wait, and to say when a signup email already has an account. Response status codes and shapes are unchanged; endpoint tests now pin the titles the forms rely on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The only signup email read like an account activation gate. New accounts now get a short welcome that says the account already works, that confirming turns on email notifications, that the link expires in 24 hours, and where to go next. Resent and changed-address confirmations keep a plain confirmation message without the welcome. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
First-run setup creates an organization and project, then lists the organization's projects. The list could be fetched before Elasticsearch indexed the new project, so it came back empty and stayed cached: the "Set up your first project" banner and Exie's checklist kept showing after setup and even after the first event. Create both with immediate consistency, and add the new project to every cached project list for its organization. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…kers # Conflicts: # src/Exceptionless.Web/Api/Handlers/OrganizationHandler.cs # src/Exceptionless.Web/Api/Handlers/ProjectHandler.cs # src/Exceptionless.Web/ClientApp/e2e/fixtures/api-client.ts # src/Exceptionless.Web/ClientApp/e2e/tests/email-verification.e2e.ts # src/Exceptionless.Web/ClientApp/src/lib/features/organizations/components/organization-notifications.svelte # src/Exceptionless.Web/ClientApp/src/lib/features/organizations/components/organization-notifications.svelte.test.ts # src/Exceptionless.Web/ClientApp/src/routes/(app)/account/verify/+page.svelte # src/Exceptionless.Web/ClientApp/src/routes/(app)/account/verify/verify-page.svelte.test.ts
Invited users who sign up with a different address still get a confirmation email, but they join an organization that already has apps, so the "connect your app" next step doesn't apply. Also stop the email implying confirmation only turns on notifications.
The organization key prefix also matches non-list queries, so check for an array before appending. Also apply formatting to the merge resolutions.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bugs that stopped a new user from getting from signup to their first event cleanly. This is the base for the Exie onboarding PR stacked on top.
Changes
Breaking changes and deploy notes
Testing
npm run validateis clean and unit tests pass.