Skip to content

Fix onboarding blockers from signup to first event - #2735

Merged
ejsmith merged 10 commits into
mainfrom
issue/onboarding-blockers
Nov 19, 2026
Merged

ejsmith merged 10 commits into
mainfrom
issue/onboarding-blockers

Conversation

@ejsmith

@ejsmith ejsmith commented Nov 19, 2026

Copy link
Copy Markdown
Member

Fixes the bugs that stopped a new user from getting from signup to their first event cleanly. This is the base for the Exie onboarding PR stacked on top.

Changes

Problem a new user hit Fix
Email verification links failed Links verify correctly. A reused link says so instead of erroring.
The setup page didn't notice the first event Project configuration changes now reach the browser over WebSockets
A just-created project or org was missing from lists It is searchable before the API responds
The Free upsell appeared before the project was set up Setup prompts show first
Auth errors were vague Rate-limited signups and existing accounts get clear messages
The confirmation email was a bare "verify" New accounts get a welcome. Invited users get a plain verify email with no connect-your-app pitch.
flowchart LR
  A[Sign up] --> B[Verify email] --> C[Create project] --> D[Send first event]
  D -- WebSocket --> E[Setup page sees it]
Loading
  • The cache now only appends a new project to cached lists that are actually arrays, so other cached shapes no longer break.

Breaking changes and deploy notes

  • None

Testing

  • npm run validate is clean and unit tests pass.
  • Backend tests cover email verification, auth failures, project and org search consistency, and the welcome-or-verify email choice at signup.
  • E2E: the journey and email-verification specs pass.

ejsmith and others added 10 commits October 21, 2026 12:34
Marking a project configured after its first event used an id-only patch.
That notification carries no organization id, so the web socket broker
dropped it and onboarding prompts stayed stale until a manual refresh.
Publish the change with the project's organization while still patching
only is_configured, and make it searchable before clients refetch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The verify page posted to a route that does not exist, so every emailed
verification link failed. Call the GET endpoint with the token as an
encoded path segment, explain missing, invalid, used, and expired links,
and refresh the current user so the "Email not verified" prompt clears.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The add project form now submits with "Continue to Client Setup".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Free organizations with no projects saw the free plan upsell instead of
the prompt to add a first project. Order organization notices so account
problems come first, then setup steps, then upgrade prompts. Also fix the
"Set up" wording and keep only one playful line across the setup notices.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every 401 from login or signup showed "Invalid email or password",
including rate-limit denials. Use the existing problem titles to tell
users when they need to wait, and to say when a signup email already has
an account. Response status codes and shapes are unchanged; endpoint tests
now pin the titles the forms rely on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The only signup email read like an account activation gate. New accounts
now get a short welcome that says the account already works, that
confirming turns on email notifications, that the link expires in 24
hours, and where to go next. Resent and changed-address confirmations
keep a plain confirmation message without the welcome.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
First-run setup creates an organization and project, then lists the
organization's projects. The list could be fetched before Elasticsearch
indexed the new project, so it came back empty and stayed cached: the
"Set up your first project" banner and Exie's checklist kept showing
after setup and even after the first event. Create both with immediate
consistency, and add the new project to every cached project list for
its organization.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…kers

# Conflicts:
#	src/Exceptionless.Web/Api/Handlers/OrganizationHandler.cs
#	src/Exceptionless.Web/Api/Handlers/ProjectHandler.cs
#	src/Exceptionless.Web/ClientApp/e2e/fixtures/api-client.ts
#	src/Exceptionless.Web/ClientApp/e2e/tests/email-verification.e2e.ts
#	src/Exceptionless.Web/ClientApp/src/lib/features/organizations/components/organization-notifications.svelte
#	src/Exceptionless.Web/ClientApp/src/lib/features/organizations/components/organization-notifications.svelte.test.ts
#	src/Exceptionless.Web/ClientApp/src/routes/(app)/account/verify/+page.svelte
#	src/Exceptionless.Web/ClientApp/src/routes/(app)/account/verify/verify-page.svelte.test.ts
Invited users who sign up with a different address still get a confirmation
email, but they join an organization that already has apps, so the "connect
your app" next step doesn't apply. Also stop the email implying confirmation
only turns on notifications.
The organization key prefix also matches non-list queries, so check for an
array before appending. Also apply formatting to the merge resolutions.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T00:06:53.146848Z c737627 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.AppHost 23% 22% 130 ❌
Exceptionless.Core 78% 70% 11215 ✔
Exceptionless.Insulation 51% 43% 370 ➖
Exceptionless.Web 87% 73% 10316 ✔
Summary 81% (29968 / 36870) 71% (15322 / 21586) 22031 ✔

@ejsmith
ejsmith merged commit a76b556 into main Nov 19, 2026
22 checks passed
@ejsmith
ejsmith deleted the issue/onboarding-blockers branch November 19, 2026 04:50
ejsmith added a commit that referenced this pull request Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant