Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3712e10a48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public static string GetActiveIndexCacheKey(string organizationId) => $"{GetOrganizationIndexCacheKey(organizationId)}:active"; | ||
| public static string GetUpdateLockResource(string id) => $"{KeyPrefix}:update:{id}"; | ||
| public static string GetCreateLockResource(string organizationId) => $"{KeyPrefix}:create:{organizationId}"; | ||
| public static string GetCreateLockResource(string organizationId) => $"{GetOrganizationIndexCacheKey(organizationId)}:create"; |
There was a problem hiding this comment.
Preserve the existing distributed creation lock key
During a deployment with old and new API instances running together, this changes the organization lock from background-tasks:create:{organizationId} to background-tasks:organization:{organizationId}:create. The two versions therefore acquire independent locks in BulkOperationService.CreateAsync, allowing simultaneous requests to both pass FindConflictingTaskAsync before either task is indexed and enqueue overlapping destructive operations. The API Deployment in k8s/exceptionless/templates/api.yaml does not require a stop-the-world upgrade. Preserve the previous lock resource string while centralizing its construction so mixed-version instances retain mutual exclusion.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 20178fa. The creation lock retains its original resource name across API versions. The regression check failed with the renamed key and passed after the fix, alongside all 41 task and bulk service tests.
Bulk deletes reject malformed time ranges, invalid UTC offsets, and unreadable saved selections before they can change which events are deleted. This PR is stacked on #2713.
Changes
Breaking changes and deploy notes
Testing
261 focused tests passed for the initial fixes. The follow-up passed 156 affected tests covering tasks, bulk operations, offsets, and cleanup. A separate Redis 8.6 check verified index expiry and tenant cleanup.