Extbans placed by users on a channel through ChanServ are not properly expired, stays active forever

[Robby-]

Extbans placed by users on a channel through ChanServ are not properly expired, stays active forever.

• The channel is configured with a ban-time of 1 minute for speedier testing/reproduction.
• Set the ban: /CS BAN #channel +b m:*!*@example.com (observe ChanServ is setting the ban)
• Wait approximately 1 to 2 minutes (as expiration doesn't happen that precisely to the minute).
• Observe that the ban is not being removed by the bot.

This is possibly a regression caused by #1880 as we didn't have this issue before.

This is tested with InspIRCd 4.10.1 and the default setting of <options:extbanformat="name"> in inspircd.conf.

Due to the above mentioned InspIRCd setting, an interesting observation I made is, if the extban is set manually using their letter, for example for mute it is m, then the ircd transforms /MODE #channel +b m:*!*@example.com into /MODE #channel +b mute:*!*@example.com which is functionally the same, but then the ban does expire properly and is removed by Eggdrop as expected. However, if it is set via ChanServ, this transformation doesn't happen and the bot does not expire the ban and remains active forever.

[Robby-]

Some more testing shows that using anything shorter than 3 characters for extbans are not being expired by Eggdrop. However, using 3 or more characters as extbans are being properly expired.

So, it seems that it is some length checking issue.

• Set these bans: /MODE #channel +bbbb e:*!*@example.com ee:*!*@example.com eee:*!*@example.com eeee:*!*@example.com
• Wait for expiry.
• Observe that out of those 4 bans only eee:*!*@example.com and eeee:*!*@example.com are being unset.

Note that e, ee, eee and eeee are not valid extbans in InspIRCd at the time of writing and they are just used for testing and proving this bug with Eggdrop.

Note that using more than a single letter for extbans is much more future-proof as it makes adding new types of extbans easier as letters only have a finite amount and is why InspIRCd is doing this.