Skip to content

Commit 41575dc

Browse files
committed
fixup
1 parent 497156e commit 41575dc

3 files changed

Lines changed: 14 additions & 3 deletions

File tree

.github/workflows/provisioning-tests.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,10 @@ jobs:
7373
run: make dev.provision.${{matrix.services}}
7474

7575
- name: "Bring up services"
76-
run: make dev.up.${{matrix.services}}
76+
# Use the without-wait variant: this job only provisions a subset of
77+
# services, so their un-provisioned transitive dependencies can never
78+
# become healthy.
79+
run: make dev.up.without-wait.${{matrix.services}}
7780

7881
- name: "Wait for services to become ready"
7982
run: |

Makefile

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@
5555
dev.shell.cms_watcher dev.shell.xqueue dev.shell.xqueue_consumer \
5656
dev.static dev.static.lms dev.static.cms dev.stats dev.status \
5757
dev.stop dev.up dev.up.attach dev.up.shell \
58-
dev.up.without-deps dev.up.without-deps.shell dev.up.with-programs \
58+
dev.up.without-deps dev.up.without-deps.shell dev.up.without-wait \
59+
dev.up.with-programs \
5960
dev.up.with-watchers dev.validate docs \
6061
help requirements impl-dev.clone.https impl-dev.clone.ssh impl-dev.provision \
6162
impl-dev.pull impl-dev.pull.without-deps impl-dev.up impl-dev.up.attach \
@@ -262,6 +263,11 @@ dev.up.without-deps.shell.%: ## Bring up a service by itself + shell into it.
262263
make dev.up.without-deps.$*
263264
make dev.shell.$*
264265

266+
dev.up.without-wait: _expects-service-list.dev.up.without-wait
267+
268+
dev.up.without-wait.%: dev.check-memory ## Bring up services and their dependencies without waiting for them to become healthy.
269+
docker compose up -d $$(echo $* | tr + " ")
270+
265271
dev.up:
266272
@scripts/make_warn_default_large.sh "$@"
267273

provision-ida.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ client_name=$2 # The name of the Oauth client stored in the edxapp DB.
99
client_port=$3 # The port corresponding to this IDA service in devstack.
1010
container_name=${4:-$1} # (Optional) The name of the container. If missing, will use app_name.
1111

12-
make dev.up.$app_name
12+
# Launch the IDA service without --wait because generally the app cannot start
13+
# successfully before migrations are run for the first time.
14+
docker compose up -d $app_name
1315

1416
echo -e "${GREEN}Installing requirements for ${app_name}...${NC}"
1517
docker compose exec -T ${container_name} bash -e -c 'source /edx/app/$1/$1_env && cd /edx/app/$1/$1/ && make requirements' -- "$app_name"

0 commit comments

Comments
 (0)