🎨 Polish login password visibility toggle#62
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the login password visibility toggle in sleep-ui from a text-based control to an icon-based control, with theme-aware styling, and records the associated execution/lesson documentation.
Changes:
- Add eye / eye-slashed SVG assets and render them via CSS masking for the login password toggle.
- Update login page markup and shared CSS to support the new icon toggle styling and spacing.
- Add a completed execution plan and a workflow/approval-gate lesson entry documenting the process.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sleep-ui/static/icons/eye.svg | Adds the “eye” icon asset used for the visibility toggle. |
| sleep-ui/static/icons/eye-slashed.svg | Adds the “eye slashed” icon asset used for the visibility toggle. |
| sleep-ui/src/routes/login/+page.svelte | Replaces Show/Hide text with an icon span and updates input padding class. |
| sleep-ui/src/app.css | Introduces icon-mask styling and updated button sizing/hover/focus behavior. |
| docs/coding-agent/plans/completed/login-password-visibility-icons-plan.md | Records the implementation plan, validations, and reviewer evidence. |
| docs/coding-agent/lessons.md | Adds a lesson about not inferring approval from requirement clarifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/coding-agent/plans/completed/login-password-visibility-icons-plan.md
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation