Skip to content

🎨 Polish login password visibility toggle#62

Merged
ebigunso merged 6 commits intomainfrom
chore/login-password-toggle-icons
Mar 11, 2026
Merged

🎨 Polish login password visibility toggle#62
ebigunso merged 6 commits intomainfrom
chore/login-password-toggle-icons

Conversation

@ebigunso
Copy link
Owner

Summary

  • replace the login password Show/Hide text button with prepared eye icons
  • make the toggle styling cleaner and theme-aware, including consistent hover behavior
  • record the execution notes and approval-gate lesson for this change

Validation

  • cd sleep-ui && npm run check
  • cd sleep-ui && npm run test:unit
  • reviewer evidence captured for login toggle light/dark states under .playwright-cli/

Copilot AI review requested due to automatic review settings March 11, 2026 17:52
@ebigunso ebigunso self-assigned this Mar 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the login password visibility toggle in sleep-ui from a text-based control to an icon-based control, with theme-aware styling, and records the associated execution/lesson documentation.

Changes:

  • Add eye / eye-slashed SVG assets and render them via CSS masking for the login password toggle.
  • Update login page markup and shared CSS to support the new icon toggle styling and spacing.
  • Add a completed execution plan and a workflow/approval-gate lesson entry documenting the process.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
sleep-ui/static/icons/eye.svg Adds the “eye” icon asset used for the visibility toggle.
sleep-ui/static/icons/eye-slashed.svg Adds the “eye slashed” icon asset used for the visibility toggle.
sleep-ui/src/routes/login/+page.svelte Replaces Show/Hide text with an icon span and updates input padding class.
sleep-ui/src/app.css Introduces icon-mask styling and updated button sizing/hover/focus behavior.
docs/coding-agent/plans/completed/login-password-visibility-icons-plan.md Records the implementation plan, validations, and reviewer evidence.
docs/coding-agent/lessons.md Adds a lesson about not inferring approval from requirement clarifications.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Repository owner deleted a comment from Copilot AI Mar 11, 2026
@ebigunso ebigunso changed the title Polish login password visibility toggle 🎨 Polish login password visibility toggle Mar 11, 2026
@ebigunso ebigunso merged commit 61adfdc into main Mar 11, 2026
2 checks passed
@ebigunso ebigunso deleted the chore/login-password-toggle-icons branch March 11, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants