Skip to content

fix(instance): ensure proper disposal of current unit #6254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
siam-ese wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

fix(instance): ensure proper disposal of current unit #6254

siam-ese wants to merge 13 commits into from

Conversation

@siam-ese
Copy link
Contributor

@siam-ese siam-ese commented Dec 6, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@siam-ese siam-ese requested a review from jikkai as a code owner December 6, 2025 07:40
@github-actions
Copy link

github-actions bot commented Dec 6, 2025 •
edited
Loading

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@github-actions
Copy link

github-actions bot commented Dec 6, 2025 •
edited
Loading

Playwright test results

failed  1 failed
passed  26 passed

Details

stats  27 tests across 12 suites
duration  6 minutes, 42 seconds
commit  1a1206c
info  For more information, see full report

Failed tests

chromium › disposing/disposing.spec.ts › no error on constructing and disposing sheet unit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siam-ese @hexf00