Use the latest vulkan packages from Ubuntu 26.04 #444
Conversation
Users have noticed some AI-related optimizations from 25.10, as an exception, build on 26.04 for the Vulkan variant of our image. Signed-off-by: Eric Curtin <[email protected]>
Summary of ChangesHello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the underlying Ubuntu operating system version used for building the Vulkan variant of the application's Docker image. The change from Ubuntu 25.10 to 26.04 is driven by the goal of integrating recent AI-related optimizations, which are anticipated to improve performance for users relying on the Vulkan build. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and found some issues that need to be addressed.
- Since ubuntu:26.04 is not yet a standard released tag, consider verifying and/or documenting that this tag exists in the registry you use, or use a codename or LTS tag that’s guaranteed to be available to avoid build breakage.
- To improve build reproducibility, consider pinning the BASE_IMAGE to a specific image digest rather than a floating ubuntu:26.04 tag.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since ubuntu:26.04 is not yet a standard released tag, consider verifying and/or documenting that this tag exists in the registry you use, or use a codename or LTS tag that’s guaranteed to be available to avoid build breakage.
- To improve build reproducibility, consider pinning the BASE_IMAGE to a specific image digest rather than a floating ubuntu:26.04 tag.
## Individual Comments
### Comment 1
<location> `Dockerfile:8-10` </location>
<code_context>
ARG LLAMA_BINARY_PATH=/com.docker.llama-server.native.linux.${LLAMA_SERVER_VARIANT}.${TARGETARCH}
-# only 25.10 for cpu variant for max hardware support with vulkan
+# only 26.04 for cpu variant for max hardware support with vulkan
# use 22.04 for gpu variants to match ROCm/CUDA base images
-ARG BASE_IMAGE=ubuntu:25.10
+ARG BASE_IMAGE=ubuntu:26.04
FROM docker.io/library/golang:${GO_VERSION}-bookworm AS builder
</code_context>
<issue_to_address>
**issue (bug_risk):** Using ubuntu:26.04 may be invalid/non-existent and break builds
`ubuntu:26.04` is not an official tag yet, so this will likely fail at build time with “image not found.” Consider using an existing tag (e.g., 24.04 or 22.04) or making the base image configurable so you can switch to 26.04 once it’s actually published without breaking current builds.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR updates the base image for the Vulkan/CPU variant from Ubuntu 25.10 to 26.04. The change is correct for the CPU variant, ensuring the build and runtime environments match. However, this change highlights and exacerbates a pre-existing issue for GPU variants. They are built on Ubuntu 22.04 but would now be packaged into a runtime based on Ubuntu 26.04. This significant OS version mismatch can cause runtime failures due to library incompatibilities. I've added a critical comment recommending aligning the build and runtime environments to prevent such issues.
|
Should llama.cpp also be bumped in this PR? |
Makes no difference to this PR |
Users have noticed some AI-related optimizations from 25.10, as an exception, build on 26.04 for the Vulkan variant of our image.