Skip to content

Conversation

@ericcurtin
Copy link
Contributor

Update go.mod with proper pseudo-version for nested module

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue preventing successful go get operations by refining the Go module configuration. It specifically updates the pseudo-version for a nested module, corrects its declared module path, and integrates it into the Go workspace. These changes ensure proper dependency resolution and module management within the project.

Highlights

  • Go Module Configuration: The primary module's go.mod file has been updated to use a proper pseudo-version for the nested pkg/go-containerregistry module, resolving issues with go get.
  • Nested Module Path Correction: The pkg/go-containerregistry module's go.mod file now correctly declares its module path as github.com/docker/model-runner/pkg/go-containerregistry, aligning with its location within the repository.
  • Go Workspace Integration: The pkg/go-containerregistry module has been added to the go.work file, ensuring it is properly recognized and managed within the Go workspace.
  • Dependency Updates: Several dependencies across both the main go.mod and the nested module's go.mod have been updated to their latest compatible versions, along with corresponding updates in go.work.sum and pkg/go-containerregistry/go.sum.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • After changing the nested module path from github.com/google/go-containerregistry to github.com/docker/model-runner/pkg/go-containerregistry, make sure all imports in this repo (and any internal tooling/scripts) have been updated to use the new path to avoid accidental usage of the upstream module.
  • The removal of the go.work file and the replace directive for ./pkg/go-containerregistry changes how local development and multi-module edits work; if you still expect to edit the nested module in lockstep with the root, consider whether a go.work setup (or a temporary replace) would make local workflows smoother.
  • You’ve bumped several networking/telemetry dependencies (grpc, googleapis/genproto, opentelemetry, x/net/sys/time); review any usage of these libraries for API changes (e.g., context handling, metrics/tracing setup) and update call sites accordingly to match the new versions’ expectations.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- After changing the nested module path from github.com/google/go-containerregistry to github.com/docker/model-runner/pkg/go-containerregistry, make sure all imports in this repo (and any internal tooling/scripts) have been updated to use the new path to avoid accidental usage of the upstream module.
- The removal of the go.work file and the replace directive for ./pkg/go-containerregistry changes how local development and multi-module edits work; if you still expect to edit the nested module in lockstep with the root, consider whether a go.work setup (or a temporary replace) would make local workflows smoother.
- You’ve bumped several networking/telemetry dependencies (grpc, googleapis/genproto, opentelemetry, x/net/sys/time); review any usage of these libraries for API changes (e.g., context handling, metrics/tracing setup) and update call sites accordingly to match the new versions’ expectations.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin ericcurtin force-pushed the fix-docker-run-command branch from 943489a to cf4dffa Compare November 21, 2025 15:06
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly reconfigures the Go modules to fix go get for the nested go-containerregistry module. The changes involve updating the module path in pkg/go-containerregistry/go.mod, removing the local replace directive from the root go.mod, and adding the nested module to go.work for local development. These changes are idiomatic for managing nested modules in a Go workspace and appear to be correct. The dependency updates in go.mod and go.sum files are consistent with these changes. Overall, the pull request looks good and achieves its stated goal.

Update go.mod with proper pseudo-version for nested module

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin ericcurtin force-pushed the fix-docker-run-command branch from cf4dffa to 6951a2a Compare November 21, 2025 15:07
Copy link
Contributor

@doringeman doringeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@doringeman doringeman merged commit 808beb4 into main Nov 24, 2025
10 checks passed
@doringeman doringeman deleted the fix-docker-run-command branch November 24, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants