-
Notifications
You must be signed in to change notification settings - Fork 68
Fix go get by updating submodule configuration #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue preventing successful Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- After changing the nested module path from github.com/google/go-containerregistry to github.com/docker/model-runner/pkg/go-containerregistry, make sure all imports in this repo (and any internal tooling/scripts) have been updated to use the new path to avoid accidental usage of the upstream module.
- The removal of the go.work file and the replace directive for ./pkg/go-containerregistry changes how local development and multi-module edits work; if you still expect to edit the nested module in lockstep with the root, consider whether a go.work setup (or a temporary replace) would make local workflows smoother.
- You’ve bumped several networking/telemetry dependencies (grpc, googleapis/genproto, opentelemetry, x/net/sys/time); review any usage of these libraries for API changes (e.g., context handling, metrics/tracing setup) and update call sites accordingly to match the new versions’ expectations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- After changing the nested module path from github.com/google/go-containerregistry to github.com/docker/model-runner/pkg/go-containerregistry, make sure all imports in this repo (and any internal tooling/scripts) have been updated to use the new path to avoid accidental usage of the upstream module.
- The removal of the go.work file and the replace directive for ./pkg/go-containerregistry changes how local development and multi-module edits work; if you still expect to edit the nested module in lockstep with the root, consider whether a go.work setup (or a temporary replace) would make local workflows smoother.
- You’ve bumped several networking/telemetry dependencies (grpc, googleapis/genproto, opentelemetry, x/net/sys/time); review any usage of these libraries for API changes (e.g., context handling, metrics/tracing setup) and update call sites accordingly to match the new versions’ expectations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
943489a to
cf4dffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly reconfigures the Go modules to fix go get for the nested go-containerregistry module. The changes involve updating the module path in pkg/go-containerregistry/go.mod, removing the local replace directive from the root go.mod, and adding the nested module to go.work for local development. These changes are idiomatic for managing nested modules in a Go workspace and appear to be correct. The dependency updates in go.mod and go.sum files are consistent with these changes. Overall, the pull request looks good and achieves its stated goal.
Update go.mod with proper pseudo-version for nested module Signed-off-by: Eric Curtin <[email protected]>
cf4dffa to
6951a2a
Compare
doringeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Update go.mod with proper pseudo-version for nested module