Skip to content

Commit bce31d9

Browse files
committed
driver: remove handling for legacy (docker < 23.0) version
Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 823e824 commit bce31d9

File tree

8 files changed

+164
-350
lines changed

8 files changed

+164
-350
lines changed

builder/node.go

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,9 @@ import (
1414
"github.com/docker/buildx/util/imagetools"
1515
"github.com/docker/buildx/util/platformutil"
1616
"github.com/moby/buildkit/client"
17-
"github.com/moby/buildkit/util/grpcerrors"
1817
ocispecs "github.com/opencontainers/image-spec/specs-go/v1"
1918
"github.com/pkg/errors"
2019
"golang.org/x/sync/errgroup"
21-
"google.golang.org/grpc/codes"
2220
)
2321

2422
type Node struct {
@@ -267,15 +265,9 @@ func (n *Node) loadData(ctx context.Context, clientOpt ...client.ClientOpt) erro
267265
n.Platforms = platformutil.Dedupe(n.Platforms)
268266
inf, err := driverClient.Info(ctx)
269267
if err != nil {
270-
if st, ok := grpcerrors.AsGRPCStatus(err); ok && st.Code() == codes.Unimplemented {
271-
n.Version, err = n.Driver.Version(ctx)
272-
if err != nil {
273-
return errors.Wrap(err, "getting version")
274-
}
275-
}
276-
} else {
277-
n.Version = inf.BuildkitVersion.Version
268+
return errors.Wrap(err, "getting version")
278269
}
270+
n.Version = inf.BuildkitVersion.Version
279271
}
280272
return nil
281273
}

driver/docker-container/driver.go

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -369,22 +369,6 @@ func (d *Driver) Info(ctx context.Context) (*driver.Info, error) {
369369
}, nil
370370
}
371371

372-
func (d *Driver) Version(ctx context.Context) (string, error) {
373-
bufStdout := &bytes.Buffer{}
374-
bufStderr := &bytes.Buffer{}
375-
if err := d.run(ctx, []string{"buildkitd", "--version"}, bufStdout, bufStderr); err != nil {
376-
if bufStderr.Len() > 0 {
377-
return "", errors.Wrap(err, bufStderr.String())
378-
}
379-
return "", err
380-
}
381-
version := strings.Fields(bufStdout.String())
382-
if len(version) != 4 {
383-
return "", errors.Errorf("unexpected version format: %s", bufStdout.String())
384-
}
385-
return version[2], nil
386-
}
387-
388372
func (d *Driver) Stop(ctx context.Context, force bool) error {
389373
info, err := d.Info(ctx)
390374
if err != nil {

driver/docker/driver.go

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package docker
33
import (
44
"context"
55
"net"
6-
"strings"
76
"sync"
87

98
"github.com/docker/buildx/driver"
@@ -38,19 +37,6 @@ func (d *Driver) Info(ctx context.Context) (*driver.Info, error) {
3837
}, nil
3938
}
4039

41-
func (d *Driver) Version(ctx context.Context) (string, error) {
42-
v, err := d.DockerAPI.ServerVersion(ctx, dockerclient.ServerVersionOptions{})
43-
if err != nil {
44-
return "", errors.Wrap(driver.ErrNotConnecting{}, err.Error())
45-
}
46-
// TODO(thaJeztah): this code is only used for docker <= v23.0, which are deprecated.
47-
if bkversion, _ := resolveBuildKitVersion(v.Version); bkversion != "" {
48-
return bkversion, nil
49-
}
50-
// https://github.com/moby/moby/blob/efc7a2abc3ab6dfa7d8d5d8c1c3b99138989b0f1/builder/builder-next/worker/worker.go#L176
51-
return strings.TrimSuffix(v.Version, "-moby"), nil
52-
}
53-
5440
func (d *Driver) Stop(ctx context.Context, force bool) error {
5541
return nil
5642
}

driver/docker/version.go

Lines changed: 0 additions & 185 deletions
This file was deleted.

0 commit comments

Comments
 (0)