Skip to content

Commit d5c292c

Browse files
committed
ensure no unnecessary ai summaries generated
1 parent a18156d commit d5c292c

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

backend/controllers/projects_helpers.go

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,12 @@ func UpdateCheckRunForBatch(gh utils.GithubClientProvider, batch *models.DiggerB
210210
return fmt.Errorf("error generating realtime comment message: %v", err)
211211
}
212212

213-
summary, err := GenerateChecksSummaryForBatch(batch)
214-
if err != nil {
215-
slog.Warn("Error generating checks summary for batch", "batchId", batch.ID, "error", err)
213+
var summary = ""
214+
if batch.Status == orchestrator_scheduler.BatchJobSucceeded || batch.Status == orchestrator_scheduler.BatchJobFailed {
215+
summary, err = GenerateChecksSummaryForBatch(batch)
216+
if err != nil {
217+
slog.Warn("Error generating checks summary for batch", "batchId", batch.ID, "error", err)
218+
}
216219
}
217220

218221
if isPlanBatch {
@@ -397,11 +400,15 @@ func UpdateCheckRunForJob(gh utils.GithubClientProvider, job *models.DiggerJob)
397400
"```\n"
398401

399402

400-
summary, err := GenerateChecksSummaryForJob(job)
401-
if err != nil {
402-
slog.Warn("Error generating checks summary for batch", "batchId", batch.ID, "error", err)
403+
var summary = ""
404+
if job.Status == orchestrator_scheduler.DiggerJobSucceeded || job.Status == orchestrator_scheduler.DiggerJobFailed {
405+
summary, err = GenerateChecksSummaryForJob(job)
406+
if err != nil {
407+
slog.Warn("Error generating checks summary for batch", "batchId", batch.ID, "error", err)
408+
}
403409
}
404410

411+
405412
slog.Debug("Updating PR status for job", "jobId", job.DiggerJobID, "status", status, "conclusion", conclusion)
406413
if isPlan {
407414
title := fmt.Sprintf("%v to create %v to update %v to delete", job.DiggerJobSummary.ResourcesCreated, job.DiggerJobSummary.ResourcesUpdated, job.DiggerJobSummary.ResourcesDeleted)

0 commit comments

Comments
 (0)