Merge pull request #2103 from diggerhq/diggerUIBugFix

Digger UI bug fix

Author: jamesboi951

backend/controllers/github.go

@@ -2454,9 +2454,31 @@ jobs:
 }
 
 func (d DiggerController) GithubAppCallbackPage(c *gin.Context) {
-	installationId := c.Request.URL.Query()["installation_id"][0]
+	installationIdParams, installationIdExists := c.Request.URL.Query()["installation_id"]
+	if !installationIdExists || len(installationIdParams) == 0 {
+		slog.Error("There was no installation_id in the url query parameters")
+		c.String(http.StatusBadRequest, "could not find the installation_id query parameter for github app")
+		return
+	}
+	installationId := installationIdParams[0]
+	if len(installationId) < 1 {
+		slog.Error("Installation_id parameter is empty")
+		c.String(http.StatusBadRequest, "installation_id parameter for github app is empty")
+		return
+	}
 	//setupAction := c.Request.URL.Query()["setup_action"][0]
-	code := c.Request.URL.Query()["code"][0]
+	codeParams, codeExists := c.Request.URL.Query()["code"]
+	if !codeExists || len(codeParams) == 0 {
+		slog.Error("There was no code in the url query parameters")
+		c.String(http.StatusBadRequest, "could not find the code query parameter for github app")
+		return
+	}
+	code := codeParams[0]
+	if len(code) < 1 {
+		slog.Error("Code parameter is empty")
+		c.String(http.StatusBadRequest, "code parameter for github app is empty")
+		return
+	}
 	appId := c.Request.URL.Query().Get("state")
 
 	slog.Info("Processing GitHub app callback", "installationId", installationId, "appId", appId)