Add support for more expression types in diesel_infer_schema #4869
+1,878
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
infer_query/more_expressions
branch
2 times, most recently
from
a0cdb3d to
25899d2
Compare
This commit adds support for more expression types to diesel_infer_schema. After this change we have limited support for wild cards, function calls, binary operations and some special operations like `BETWEEN` and `CASE WHEN`. This hopefully helps to infer slightly more complex view definitions correctly. I still expect at least one or two other rounds of additions here to support subqueries and more complicated constructs (CTE's, UNION's, etc) as well.
weiznich
force-pushed
the
infer_query/more_expressions
branch
from
25899d2 to
ddeb67a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for more expression types to diesel_infer_schema. After this change we have limited support for wild cards, function calls, binary operations and some special operations like
BETWEENandCASE WHEN. This hopefully helps to infer slightly more complex view definitions correctly.I still expect at least one or two other rounds of additions here to support subqueries and more complicated constructs (CTE's, UNION's, etc) as well.