feat: update button icon animation#264
Draft
cooper-joe wants to merge 3 commits into
Draft
Conversation
|
🚀 Deployed on https://pr-264.event-visualizer.netlify.dhis2.org |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR animates the Update button icon on click. The animation is also triggered when updating via a modal dialog or when switching to another output type. The animation does not play when creating a visualisation for the first time as this felt wrong.
(This feature is in response to user feedback where there was an underlying feeling of "did anything happen"?)
Note: The animation does not play when updating from a custom value modal dialog, but that is a bug with that dialog, not in the animation. Fix for that should outside the scope of this PR.
Quality checklist
Add N/A to items that are not applicable and check them.
Screenshots
Kapture.2026-06-08.at.16.04.12.mp4