Deduplicate code for setting nested array value

Author: theodorejb

src/Helpers.php

@@ -44,23 +44,28 @@ public static function propMapToSelectMap(array $map): array
         $selectMap = [];
 
         foreach ($map as $prop) {
-            $key = $prop->map[0];
-            /** @psalm-suppress EmptyArrayAccess */
-            $_ref = &$selectMap[$key];
-
-            for ($i = 1; $i < $prop->depth; $i++) {
-                $key = $prop->map[$i];
-                /** @psalm-suppress MixedArrayAccess */
-                $_ref = &$_ref[$key];
-            }
-
-            $_ref = $prop->col;
-            unset($_ref); // dereference
+            self::setNestedValue($selectMap, $prop->map, $prop->col);
         }
 
         return $selectMap;
     }
 
+    /**
+     * @param array<string, mixed> $array
+     * @param string[] $path
+     */
+    private static function setNestedValue(array &$array, array $path, mixed $value): void
+    {
+        $arr = &$array;
+
+        foreach ($path as $key) {
+            /** @phpstan-ignore offsetAccess.nonOffsetAccessible */
+            $arr = &$arr[$key];
+        }
+
+        $arr = $value;
+    }
+
     /**
      * @param \Generator<int, array> $rows
      * @param Prop[] $fieldProps
@@ -111,34 +116,12 @@ public static function mapRows(\Generator $rows, array $fieldProps): array
                     continue;
                 }
 
-                $key = $prop->map[0];
-                /** @psalm-suppress EmptyArrayAccess */
-                $_ref = &$entity[$key];
-
-                for ($i = 1; $i < $prop->depth; $i++) {
-                    $key = $prop->map[$i];
-                    /** @psalm-suppress MixedArrayAccess */
-                    $_ref = &$_ref[$key];
-                }
-
-                $_ref = $value;
-                unset($_ref); // dereference
+                self::setNestedValue($entity, $prop->map, $value);
             }
 
             foreach ($nullParents as $prop) {
-                $depth = $prop->depth - 1;
-                $key = $prop->map[0];
-                /** @psalm-suppress EmptyArrayAccess */
-                $_ref = &$entity[$key];
-
-                for ($i = 1; $i < $depth; $i++) {
-                    $key = $prop->map[$i];
-                    /** @psalm-suppress MixedArrayAccess */
-                    $_ref = &$_ref[$key];
-                }
-
-                $_ref = null;
-                unset($_ref); // dereference
+                $path = array_slice($prop->map, 0, -1);
+                self::setNestedValue($entity, $path, null);
             }
 
             $entities[] = $entity;

src/Prop.php

@@ -17,7 +17,6 @@ class Prop
      * @var string[]
      */
     public readonly array $map;
-    public readonly int $depth;
 
     /**
      * @var string[]
@@ -41,17 +40,17 @@ public function __construct(
     ) {
         $this->output = $output;
         $this->map = explode('.', $name);
-        $this->depth = count($this->map);
+        $depth = count($this->map);
         $parent = '';
         $parents = [];
 
-        for ($i = 0; $i < $this->depth - 1; $i++) {
+        for ($i = 0; $i < $depth - 1; $i++) {
             $parent .= $this->map[$i] . '.';
             $parents[] = $parent;
         }
         $this->parents = $parents;
 
-        if ($nullGroup && $this->depth < 2) {
+        if ($nullGroup && $depth < 2) {
             throw new \Exception("nullGroup cannot be set on top-level {$name} property");
         }