Skip to content

Commit 82449f8

Browse files
devillclaude
andcommitted
Inline single-use variables in baseline-violations.ts
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 8fd304d commit 82449f8

2 files changed

Lines changed: 6 additions & 20 deletions

File tree

.quality-baseline.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,6 @@
123123
"singleUseVariable"
124124
]
125125
},
126-
"src/dev/quality/baseline-violations.ts": {
127-
"lastCommitId": "72f0b80a2c1206e923102a707e6bb7d401905fb6",
128-
"violations": [
129-
"singleUseVariable"
130-
]
131-
},
132126
"src/dev/quality/glob-resolver.ts": {
133127
"lastCommitId": "be5cc3acf1456dadbabb98b89389deab64a82c62",
134128
"violations": [

src/dev/quality/baseline-violations.ts

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@ const buildFileViolationsMap = (issues: QualityIssue[]): Map<string, Set<string>
2020
const fileViolations = new Map<string, Set<string>>();
2121

2222
issues.forEach(issue => {
23-
const filePath = issue.file;
24-
if (filePath) {
25-
addViolationToMap(fileViolations, filePath, issue.type);
23+
if (issue.file) {
24+
addViolationToMap(fileViolations, issue.file, issue.type);
2625
}
2726
});
2827

@@ -51,24 +50,17 @@ const buildBaselineFromViolations = (fileViolations: Map<string, Set<string>>):
5150
};
5251

5352
export const generateBaseline = (issues: QualityIssue[]): QualityBaseline => {
54-
const blacklistedTypes = getBlacklistedTypes();
55-
const relevantIssues = issues.filter(issue => blacklistedTypes.includes(issue.type));
56-
const fileViolations = buildFileViolationsMap(relevantIssues);
57-
return buildBaselineFromViolations(fileViolations);
53+
return buildBaselineFromViolations(buildFileViolationsMap(issues.filter(issue => getBlacklistedTypes().includes(issue.type))));
5854
};
5955

6056
const filterRelevantIssues = (issues: QualityIssue[]): QualityIssue[] => {
61-
const blacklistedTypes = getBlacklistedTypes();
62-
return issues.filter(issue => blacklistedTypes.includes(issue.type) && issue.file);
57+
return issues.filter(issue => getBlacklistedTypes().includes(issue.type) && issue.file);
6358
};
6459

6560
export const buildCurrentViolationsMap = (issues: QualityIssue[]): Map<string, Set<string>> => {
6661
const currentViolations = new Map<string, Set<string>>();
67-
const relevantIssues = filterRelevantIssues(issues);
68-
69-
relevantIssues.forEach(issue => {
70-
const filePath = issue.file as string;
71-
addViolationToMap(currentViolations, filePath, issue.type);
62+
filterRelevantIssues(issues).forEach(issue => {
63+
addViolationToMap(currentViolations, issue.file as string, issue.type);
7264
});
7365

7466
return currentViolations;

0 commit comments

Comments
 (0)