Stop Appveyor, if hostname is wrong

[andreasjordan]

Summarize Functionality

Sometime, the image starts with a very long random hostname. Normaly it is changed to "appveyor-vm".

I will add some code to test this befor starting the test...

Is there a command that is similiar or close to what you are looking for?

Yes

Technical Details

No response

[niphlod]

hmm.... maybe a better fix is that the test shouldn't rely on a VM being called "whatever" or the hostname being "at most long x characters" .

[andreasjordan]

I agree. But it is really only once in a while that the hostname is "av-(GUID)". So we are not able to test if the tests work with that hostname. I just "rerun the incomplete" and it works a s expected. So failing fast if hostname is too long is a good quick fix.

[niphlod]

still not convinced it's a good idea: if the "failing test" fails if a hostname is "long", it very may well be that either the test or the underlying function are not working with "long" hostnames.

[andreasjordan]

You are absolutely right. But how can we test that? I could build a lab with a "long hostname" and test all commands and all tests. But I think that is an edge case where I don't want to invest time into. And we could never test that on AppVeyor.

But ok, I will not change anything and just let this issue here to hold the screenshot.

[niphlod]

ok, but let's separate things: "I don't want to invest time into" is very different from "I don't want the test to test it" ^_^

For starters, every function failing from when "by mistake" the env where the test is run into has a long "hostname" should be "tagged for review".
Then, in due time, people "having time to invest into" can look extensively into the "failure" so the underlying code can be fixed.