From 8c5ed4a334d2230feafb7f60e4619016ac659057 Mon Sep 17 00:00:00 2001 From: Cesar Carruitero Date: Wed, 16 Aug 2017 19:58:53 -0500 Subject: [PATCH 01/12] fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a565f96..7d2e63c 100644 --- a/README.md +++ b/README.md @@ -191,4 +191,4 @@ Willy Aguirre ([@marti1125](https://github.com/marti1125) - Team Culqi) ## Licencia -El código fuente de culqi-python está distribuido bajo MIT License, revisar el archivo [LICENSE](https://github.com/culqi/culqi-ruby/blob/master/LICENSE). +El código fuente de culqi-ruby está distribuido bajo MIT License, revisar el archivo [LICENSE](https://github.com/culqi/culqi-ruby/blob/master/LICENSE). From 57b5564d99a97df0db6f57a7540f001c0f6be494 Mon Sep 17 00:00:00 2001 From: Cesar Carruitero Date: Sat, 2 Sep 2017 12:07:35 -0500 Subject: [PATCH 02/12] use interpolation to concatenate strings --- lib/culqi/charge.rb | 2 +- lib/operation/delete.rb | 2 +- lib/operation/get.rb | 2 +- lib/operation/update.rb | 4 ++-- lib/util/connect.rb | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/culqi/charge.rb b/lib/culqi/charge.rb index f4115b5..ca7c661 100644 --- a/lib/culqi/charge.rb +++ b/lib/culqi/charge.rb @@ -11,7 +11,7 @@ class Charge @url = URL def self.capture(id) - response = Culqi.connect(URL+id+"/capture/", Culqi.secret_key, nil, "post", Culqi::READ_TIMEOUT) + response = Culqi.connect("#{@url}#{id}/capture/", Culqi.secret_key, nil, "post", Culqi::READ_TIMEOUT) return response.read_body end diff --git a/lib/operation/delete.rb b/lib/operation/delete.rb index d0bda22..c77cf31 100644 --- a/lib/operation/delete.rb +++ b/lib/operation/delete.rb @@ -7,7 +7,7 @@ def initialize end def delete(id) - response = Culqi.connect(@url+id+'/', Culqi.secret_key, nil, 'delete', Culqi::READ_TIMEOUT) + response = Culqi.connect("#{@url}#{id}/", Culqi.secret_key, nil, 'delete', Culqi::READ_TIMEOUT) return response.read_body end diff --git a/lib/operation/get.rb b/lib/operation/get.rb index 2097b26..d49dc3e 100644 --- a/lib/operation/get.rb +++ b/lib/operation/get.rb @@ -7,7 +7,7 @@ def initialize end def get(id) - response = Culqi.connect(@url+id+'/', Culqi.secret_key, nil, 'get', Culqi::READ_TIMEOUT) + response = Culqi.connect("#{@url}#{id}/", Culqi.secret_key, nil, 'get', Culqi::READ_TIMEOUT) return response.read_body end diff --git a/lib/operation/update.rb b/lib/operation/update.rb index 23a3fa9..43fdc83 100644 --- a/lib/operation/update.rb +++ b/lib/operation/update.rb @@ -7,8 +7,8 @@ def initialize end def update(id, params={}) - response = Culqi.connect(@url+id+'/', Culqi.secret_key, params, 'patch', Culqi::READ_TIMEOUT) + response = Culqi.connect("#{@url}#{id}/", Culqi.secret_key, params, 'patch', Culqi::READ_TIMEOUT) return response.read_body end -end \ No newline at end of file +end diff --git a/lib/util/connect.rb b/lib/util/connect.rb index 032b4cf..400cb34 100644 --- a/lib/util/connect.rb +++ b/lib/util/connect.rb @@ -8,7 +8,7 @@ module Culqi def self.connect(url, api_key, data, type, time_out) - url = URI(Culqi::API_BASE+"#{url}") + url = URI("#{Culqi::API_BASE}#{url}") http = Net::HTTP.new(url.host, url.port) http.read_timeout = time_out From c2e8ebc7f3ca1b465807106d8ecda16e6b0bb167 Mon Sep 17 00:00:00 2001 From: Cesar Carruitero Date: Sat, 2 Sep 2017 12:27:02 -0500 Subject: [PATCH 03/12] add missing link --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7d2e63c..34edc4c 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ Biblioteca de CULQI para el lenguaje Ruby, pagos simples en tu sitio web. Consum ## Requisitos - Ruby >= 2.0.0 -- Credenciales de comercio en Culqi (1). +- Credenciales de comercio en Culqi [1](https://www.culqi.com/docs/#/cuenta/cuenta). ## Ejemplos From a4847b955720b5003eb96c38433b134df7c2cf54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Corcuera?= Date: Sun, 3 Sep 2017 16:20:46 -0500 Subject: [PATCH 04/12] Use Culqi module to scope operations. --- lib/operation/delete.rb | 2 +- lib/operation/get.rb | 2 +- lib/operation/list.rb | 2 +- lib/operation/post.rb | 2 +- lib/operation/update.rb | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/operation/delete.rb b/lib/operation/delete.rb index c77cf31..e4eada7 100644 --- a/lib/operation/delete.rb +++ b/lib/operation/delete.rb @@ -1,6 +1,6 @@ require 'util/connect' -module Delete +module Culqi::Delete def initialize @url = '' diff --git a/lib/operation/get.rb b/lib/operation/get.rb index d49dc3e..85bbf58 100644 --- a/lib/operation/get.rb +++ b/lib/operation/get.rb @@ -1,6 +1,6 @@ require 'util/connect' -module Get +module Culqi::Get def initialize @url = '' diff --git a/lib/operation/list.rb b/lib/operation/list.rb index 4e069fc..a6ddc6c 100644 --- a/lib/operation/list.rb +++ b/lib/operation/list.rb @@ -1,6 +1,6 @@ require 'util/connect' -module List +module Culqi::List def initialize @url = '' diff --git a/lib/operation/post.rb b/lib/operation/post.rb index 9804353..8f1c288 100644 --- a/lib/operation/post.rb +++ b/lib/operation/post.rb @@ -1,6 +1,6 @@ require 'util/connect' -module Post +module Culqi::Post def initialize @url = '' diff --git a/lib/operation/update.rb b/lib/operation/update.rb index 43fdc83..f417d38 100644 --- a/lib/operation/update.rb +++ b/lib/operation/update.rb @@ -1,6 +1,6 @@ require 'util/connect' -module Update +module Culqi::Update def initialize @url = '' From 5fbc5453e6126003f048ed902ff49d19f44b1678 Mon Sep 17 00:00:00 2001 From: Willy Aguirre Date: Mon, 4 Sep 2017 22:36:43 -0500 Subject: [PATCH 05/12] new version 0.0.8 --- CHANGELOG | 4 ++++ README.md | 2 +- culqi-ruby.gemspec | 2 +- i.sh | 4 ++-- lib/culqi/version.rb | 2 +- test/test_culqi-ruby.rb | 4 ++-- 6 files changed, 11 insertions(+), 7 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 9fcfb87..cd8ac02 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,7 @@ +### 0.0.8 04-09-2017 +* Use Culqi module to scope operations +* Use interpolation to concatenate strings + ### 0.0.7 08-04-2017 * Add update method to Customer diff --git a/README.md b/README.md index 34edc4c..150b822 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ Biblioteca de CULQI para el lenguaje Ruby, pagos simples en tu sitio web. Consum | Versión actual|Culqi API| |----|----| -| [0.0.7](https://rubygems.org/gems/culqi-ruby) (2017-04-08) |[v2](https://culqi.com/api)| +| [0.0.8](https://rubygems.org/gems/culqi-ruby) (2017-09-04) |[v2](https://culqi.com/api)| ## Requisitos diff --git a/culqi-ruby.gemspec b/culqi-ruby.gemspec index 3de6eca..055cd59 100644 --- a/culqi-ruby.gemspec +++ b/culqi-ruby.gemspec @@ -5,7 +5,7 @@ require 'culqi/version' Gem::Specification.new do |s| s.name = 'culqi-ruby' s.version = Culqi::VERSION - s.date = '2017-04-08' + s.date = '2017-09-04' s.summary = "Culqi Ruby" s.description = "Biblioteca de Culqi en Ruby API v2" s.authors = ["Willy Aguirre"] diff --git a/i.sh b/i.sh index db6900a..a8cbf10 100755 --- a/i.sh +++ b/i.sh @@ -1,3 +1,3 @@ -sudo gem uninstall culqi-ruby-0.0.7.gem +sudo gem uninstall culqi-ruby-0.0.8.gem gem build culqi-ruby.gemspec -sudo gem install culqi-ruby-0.0.7.gem +sudo gem install culqi-ruby-0.0.8.gem diff --git a/lib/culqi/version.rb b/lib/culqi/version.rb index 0d65d21..185f8a5 100644 --- a/lib/culqi/version.rb +++ b/lib/culqi/version.rb @@ -1,3 +1,3 @@ module Culqi - VERSION = "0.0.7" + VERSION = "0.0.8" end diff --git a/test/test_culqi-ruby.rb b/test/test_culqi-ruby.rb index e864f6c..93a7889 100644 --- a/test/test_culqi-ruby.rb +++ b/test/test_culqi-ruby.rb @@ -5,8 +5,8 @@ class CulqiTest < Minitest::Test - Culqi.public_key = ENV['LLAVE_PUBLICA'] - Culqi.secret_key = ENV['LLAVE_SECRETA'] + Culqi.public_key = ENV['PUBLIC_KEY'] + Culqi.secret_key = ENV['SECRET_KEY'] def getToken From b9a5d0f64f9c91c76bb3799e306a8e50a79af30a Mon Sep 17 00:00:00 2001 From: Willy Aguirre Date: Mon, 4 Sep 2017 22:56:18 -0500 Subject: [PATCH 06/12] fixed tests --- test/test_list.rb | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/test/test_list.rb b/test/test_list.rb index b776b7e..3463ceb 100644 --- a/test/test_list.rb +++ b/test/test_list.rb @@ -4,7 +4,7 @@ class TestList < Minitest::Test - Culqi.secret_key = ENV['LLAVE_SECRETA'] + Culqi.secret_key = ENV['SECRET_KEY'] def test_tokens assert_operator JSON.parse(Culqi::Token.list())['data'].count, :>=, 0 @@ -26,10 +26,6 @@ def test_cards assert_operator JSON.parse(Culqi::Card.list())['data'].count, :>=, 0 end - def test_subscriptions - assert_operator JSON.parse(Culqi::Subscription.list())['data'].count, :>=, 0 - end - def test_refunds assert_operator JSON.parse(Culqi::Refund.list())['data'].count, :>=, 0 end @@ -42,4 +38,4 @@ def test_transfers assert_operator JSON.parse(Culqi::Transfer.list())['data'].count, :>=, 0 end -end \ No newline at end of file +end From e0389f8518f94ebf7b40dbafa140cc6837e7482d Mon Sep 17 00:00:00 2001 From: Willy Aguirre Date: Mon, 4 Sep 2017 23:17:37 -0500 Subject: [PATCH 07/12] update travis --- .travis.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2aa0d8d..7de0faf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,7 +2,7 @@ language: ruby rvm: - 2.0.0 - - 2.1.0 + - 2.1 - 2.2.0 - 2.3.0 - 2.4.0 @@ -11,8 +11,6 @@ notifications: email: on_success: never -install: gem install minitest culqi-ruby - -script: rake test +script: bundle exec rake test sudo: false From 4fc6e62fbe7cda13f65cded097b6ae8d8efeea10 Mon Sep 17 00:00:00 2001 From: Willy Aguirre Date: Mon, 4 Sep 2017 23:19:54 -0500 Subject: [PATCH 08/12] update travis --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 7de0faf..500efcb 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,6 +11,8 @@ notifications: email: on_success: never +install: gem install bundle culqi-ruby + script: bundle exec rake test sudo: false From 1459ff3a27f0dfce25571fb6c12af466aa69b9c5 Mon Sep 17 00:00:00 2001 From: Willy Aguirre Date: Mon, 4 Sep 2017 23:23:16 -0500 Subject: [PATCH 09/12] update travis --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 500efcb..50b04cb 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,7 +11,7 @@ notifications: email: on_success: never -install: gem install bundle culqi-ruby +install: gem install bundler culqi-ruby script: bundle exec rake test From 0b7b9dbc0bbca5b9eaf64e8cdb74bb4ed96fb1e2 Mon Sep 17 00:00:00 2001 From: Willy Aguirre Date: Mon, 4 Sep 2017 23:33:05 -0500 Subject: [PATCH 10/12] update version of ruby in travis --- .travis.yml | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/.travis.yml b/.travis.yml index 50b04cb..0f588f4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,18 +1,16 @@ language: ruby rvm: - - 2.0.0 - - 2.1 - - 2.2.0 - - 2.3.0 - - 2.4.0 + - 2.2.7 + - 2.3.4 + - 2.4.1 notifications: email: on_success: never -install: gem install bundler culqi-ruby +install: gem install minitest culqi-ruby -script: bundle exec rake test +script: rake test sudo: false From fbd8211ccda42e81ed64a5c4d11bb3c634d59b00 Mon Sep 17 00:00:00 2001 From: Cesar Carruitero Date: Tue, 5 Sep 2017 13:49:51 -0500 Subject: [PATCH 11/12] move common test setup to test_helper --- test/test_culqi-ruby.rb | 7 +------ test/test_helper.rb | 5 +++++ test/test_list.rb | 6 +----- 3 files changed, 7 insertions(+), 11 deletions(-) create mode 100644 test/test_helper.rb diff --git a/test/test_culqi-ruby.rb b/test/test_culqi-ruby.rb index 93a7889..327dc2b 100644 --- a/test/test_culqi-ruby.rb +++ b/test/test_culqi-ruby.rb @@ -1,13 +1,8 @@ -gem 'minitest' -require 'minitest/autorun' +require 'test_helper' require 'securerandom' -require 'culqi-ruby' class CulqiTest < Minitest::Test - Culqi.public_key = ENV['PUBLIC_KEY'] - Culqi.secret_key = ENV['SECRET_KEY'] - def getToken token = Culqi::Token.create( diff --git a/test/test_helper.rb b/test/test_helper.rb new file mode 100644 index 0000000..8207ebd --- /dev/null +++ b/test/test_helper.rb @@ -0,0 +1,5 @@ +require 'minitest/autorun' +require 'culqi-ruby' + +Culqi.public_key = ENV['PUBLIC_KEY'] +Culqi.secret_key = ENV['SECRET_KEY'] diff --git a/test/test_list.rb b/test/test_list.rb index 3463ceb..34d7fa6 100644 --- a/test/test_list.rb +++ b/test/test_list.rb @@ -1,11 +1,7 @@ -gem 'minitest' -require 'minitest/autorun' -require 'culqi-ruby' +require 'test_helper' class TestList < Minitest::Test - Culqi.secret_key = ENV['SECRET_KEY'] - def test_tokens assert_operator JSON.parse(Culqi::Token.list())['data'].count, :>=, 0 end From e57154f93d96c74dbafb1a252ef07e641f918ada Mon Sep 17 00:00:00 2001 From: Adrian Meza Date: Wed, 19 Dec 2018 23:26:52 -0600 Subject: [PATCH 12/12] Added class to create orders --- lib/culqi-ruby.rb | 1 + lib/culqi/order.rb | 14 ++++++++++++++ test/test_culqi-ruby.rb | 18 ++++++++++++++++++ 3 files changed, 33 insertions(+) create mode 100644 lib/culqi/order.rb diff --git a/lib/culqi-ruby.rb b/lib/culqi-ruby.rb index ff7034e..9980902 100644 --- a/lib/culqi-ruby.rb +++ b/lib/culqi-ruby.rb @@ -15,6 +15,7 @@ require 'culqi/subscription' require 'culqi/refund' require 'culqi/transfer' +require 'culqi/order' module Culqi diff --git a/lib/culqi/order.rb b/lib/culqi/order.rb new file mode 100644 index 0000000..e5122d2 --- /dev/null +++ b/lib/culqi/order.rb @@ -0,0 +1,14 @@ +module Culqi + + class Order + + extend Post + + URL = '/orders/' + + @url = URL + + end + +end + \ No newline at end of file diff --git a/test/test_culqi-ruby.rb b/test/test_culqi-ruby.rb index 327dc2b..3db19f7 100644 --- a/test/test_culqi-ruby.rb +++ b/test/test_culqi-ruby.rb @@ -107,6 +107,24 @@ def getRefund return JSON.parse(refund) end + def getOrder + order = Culqi::Order.create( + :amount => 1000, + :currency_code => 'PEN', + :description => 'Venta de prueba', + :order_number => 'prueba-999', + :client_details => ({ + :first_name => 'Richard', + :last_name => 'Meza', + :email => 'test'+SecureRandom.uuid+'@culqi.com', + :phone_number => 998989789 + }), + :expiration_date => 2323423432, + :confirm => false + ) + return JSON.parse(order) + end + def test_1_token assert_equal 'token', getToken['object'] end