Skip to content

Use function protobufs from function-sdk-go#5

Merged
adamwg merged 1 commit intocrossplane:mainfrom
adamwg:awg/rm-crossplane-dep
May 7, 2026
Merged

Use function protobufs from function-sdk-go#5
adamwg merged 1 commit intocrossplane:mainfrom
adamwg:awg/rm-crossplane-dep

Conversation

@adamwg
Copy link
Copy Markdown
Member

@adamwg adamwg commented May 7, 2026

Description of your changes

We use the function protobufs in the function we implement for injecting and extracting context during render. When this code lived in crossplane/crossplane it made sense to use the protobufs from there, but now that we're separate it would be better to use the versions in function-sdk-go like a normal function.

This removes our dependency on crossplane/crossplane, which is nice.

I have:

We use the function protobufs in the function we implement for injecting and
extracting context during render. When this code lived in crossplane/crossplane
it made sense to use the protobufs from there, but now that we're separate it
would be better to use the versions in function-sdk-go like a normal function.

This removes our dependency on crossplane/crossplane, which is nice.

Signed-off-by: Adam Wolfe Gordon <awg@upbound.io>
@adamwg adamwg requested review from a team, jcogilvie and tampakrap as code owners May 7, 2026 20:38
@adamwg adamwg requested review from jbw976 and removed request for a team May 7, 2026 20:38
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@adamwg has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 43 minutes and 20 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 953239f9-ca54-46dd-a01f-378a55175274

📥 Commits

Reviewing files that changed from the base of the PR and between a336c13 and 2388f21.

⛔ Files ignored due to path filters (3)
  • go.mod is excluded by none and included by none
  • go.sum is excluded by !**/*.sum and included by none
  • gomod2nix.toml is excluded by none and included by none
📒 Files selected for processing (6)
  • cmd/crossplane/render/contextfn/context.go
  • cmd/crossplane/render/contextfn/context_test.go
  • cmd/crossplane/render/contextfn/listener.go
  • cmd/crossplane/render/contextfn/listener_test.go
  • cmd/crossplane/render/convert.go
  • cmd/crossplane/render/render.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@haarchri haarchri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any downsides ? negatives impacts around updating as soon as possible the sdks after crossplane updates ?

@adamwg
Copy link
Copy Markdown
Member Author

adamwg commented May 7, 2026

any downsides ? negatives impacts around updating as soon as possible the sdks after crossplane updates ?

Only downside I can see is that we'll have to update function-sdk-go to pull in any new changes in Crossplane. Any changes should be backward compatible, though, so I don't expect we'll require the latest features quickly given our usage.

@adamwg adamwg merged commit 10bac99 into crossplane:main May 7, 2026
9 checks passed
@adamwg adamwg deleted the awg/rm-crossplane-dep branch May 7, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants