feat: Implement summarization by AI ✨ #2866

lethemanh · 2025-11-21T07:55:55Z

Need:

BREAKING CHANGE: You need to add react-router-dom >= 6.14.2 as dep in your app

zatteo · 2025-11-21T15:49:11Z

packages/cozy-viewer/src/components/Toolbar.jsx

+                  className={cx(styles['viewer-ai-summarise-btn'])}
+                />
+              }
+              aria-label={t('Viewer.summriseWithAi')}


summariseWithAi

zatteo · 2025-11-21T15:50:48Z

packages/cozy-viewer/src/helpers.js

+ * @param {number} options.pdfPageCount - Number of pages if the file is a PDF
+ * @returns {boolean} Whether the file is compatible with summary
+ */
+export const isFileSummaryCompatible = (


This method is a good candidate for unit tests.

zatteo · 2025-11-21T15:52:00Z

packages/cozy-viewer/src/Panel/AI/AIAssistantPanel.jsx

+            }
+          }
+        `}
+      </style>


Can't we do something else than this?

zatteo · 2025-11-21T15:52:37Z

Code is globally very clean and understandable 👍👍

zatteo · 2025-12-02T07:36:42Z

packages/cozy-viewer/package.json

    "react-markdown": "^4.0.8",
-    "react-pdf": "^5.7.2"
+    "react-pdf": "^5.7.2",
+    "react-router-dom": "^7.9.6"


Oh I forgot:

add it in devDeps ("react-router-dom": "^6.14.2") and in peerDeps ("react-router-dom": ">=6.14.2") instead of adding it here in deps to avoid multiple version of react-router-dom

in this case, the commit become a breaking change

You need to add "BREAKING CHANGE: explanation" to the commit message before merging it so it does a major version.

Something like BREAKING CHANGE: You need to add "react-router-dom" >= 6.14.2 as dep in your app. You won't need to do anything when updating cozy-viewer in cozy-drive because it is already here but with this we keep a clean versioning.

packages/cozy-viewer/src/helpers.js

paultranvan · 2025-12-02T08:59:17Z

packages/cozy-viewer/src/helpers.js

+
+    if (config.options) {
+      const { pageLimit } = config.options
+      const { pdfPageCount } = options


This feature will not be restricted to PDF, we can have file summary on text files, office, etc
Furthermore, I assume you made the drive.summary flag an array to enable specific config per mime ?
Which is nice, but maybe a bit overkill at this point, I think we can keep it simple and just set a generic page count

If it is already here we can keep it no? But agree that pdfPageCount could be renamed (if we know page count of office file?).

It's not because it's here that it's good to keep it 😄
I think it's a good idea to keep a list of supported mimetype anywayn and we can just use a common default page number

paultranvan · 2025-12-02T13:10:57Z

packages/cozy-viewer/src/Panel/AI/AIAssistantPanel.jsx

+          role: 'user',
+          content: `Please provide a concise summary of the following document:\n\n${textContent}`
+        }
+      ]


This will be eventually externalized, but in the meantime, could you isolate the prompt in a separated file, like prompts.js ?

About the prompt itself, some improvements suggestion:

const systemPrompt = ` You are a concise and reliable text summarizer. Your goal: - Produce a clear and accurate summary of the provided content - Keep the original meaning and key information only - Remove redundancy, examples, anecdotes, and minor details Writing rules: - Keep the same language as the input - Be concise and use simple phrasing - Do not add new information - Do not guess what is not explicitly stated Output: - A single coherent paragraph unless otherwise specified - Do not add any extra information or interpret anything beyond the explicit task ` const userPrompt = `Summarize the following content:\n\n${textContent}`

+1 to keep it in a separated file from now

packages/cozy-viewer/src/Panel/AI/AIAssistantPanel.jsx

paultranvan · 2025-12-03T11:26:37Z

packages/cozy-viewer/src/Panel/AI/AIAssistantPanel.jsx

+      const textContent = await extractText(client, fileBlob, {
+        name: file.name,
+        mime: file.mime || file.class
+      })


We could add a safeguard in case there is no page info, assuming 1 token is ~4 characters.

const roughTokensEstimation = (text) => { // Assuming 1 token ~ 4 characters return Math.ceil(text.length / 4) } ... if (roughTokensEstimation(text) > summaryConfig.maxTokens) { // bye bye }

paultranvan · 2025-12-04T14:05:30Z

packages/cozy-viewer/src/Panel/AI/AIAssistantPanel.jsx

+        roughTokensEstimation(textContent) > summaryConfig.maxTokens
+      ) {
+        throw new Error(
+          `Text content exceeds maximum token limit (${summaryConfig.maxTokens} tokens)`


If this error happens, the user will have a generic error displayed, right? I think this specific error should be displayed to the user, so he can understand that the summary is not possible for this file, and not just a temporary issue where he can retry later

I've changed to this message.

BREAKING CHANGE: You need to add react-router-dom >= 6.14.2 as dep in your app ➕

lethemanh self-assigned this Nov 21, 2025

lethemanh requested review from JF-Cozy, Ldoppea, doubleface and zatteo as code owners November 21, 2025 07:55

lethemanh marked this pull request as draft November 21, 2025 07:55

This was referenced Nov 21, 2025

feat: Implement summarize file by AI ✨ linagora/twake-drive#3625

Open

feat: Implement AI assistant paywall view ✨ #2865

Merged

zatteo reviewed Nov 21, 2025

View reviewed changes

lethemanh mentioned this pull request Nov 24, 2025

Save result from summarization by ai #2868

Open

lethemanh force-pushed the implement-summarization-by-ai branch from cb9b3cd to b51cc92 Compare November 24, 2025 07:35

lethemanh requested a review from zatteo November 24, 2025 07:35

lethemanh force-pushed the implement-summarization-by-ai branch 3 times, most recently from 02b71c1 to 0e55302 Compare November 27, 2025 07:40

zatteo reviewed Dec 2, 2025

View reviewed changes

lethemanh force-pushed the implement-summarization-by-ai branch 2 times, most recently from 97a3e8e to 6908315 Compare December 2, 2025 09:31

lethemanh requested a review from zatteo December 2, 2025 09:31

paultranvan reviewed Dec 2, 2025

View reviewed changes

lethemanh force-pushed the implement-summarization-by-ai branch 2 times, most recently from 11ac343 to 9299208 Compare December 3, 2025 04:10

lethemanh requested a review from paultranvan December 3, 2025 04:10

lethemanh force-pushed the implement-summarization-by-ai branch from 9299208 to b1006f1 Compare December 3, 2025 10:08

lethemanh marked this pull request as ready for review December 3, 2025 10:09

lethemanh force-pushed the implement-summarization-by-ai branch from b1006f1 to 912fcfc Compare December 3, 2025 10:10

lethemanh force-pushed the implement-summarization-by-ai branch 2 times, most recently from 8adefdb to faeddc3 Compare December 3, 2025 10:31

zatteo approved these changes Dec 3, 2025

View reviewed changes

paultranvan reviewed Dec 3, 2025

View reviewed changes

packages/cozy-viewer/src/Panel/AI/AIAssistantPanel.jsx Outdated Show resolved Hide resolved

paultranvan reviewed Dec 3, 2025

View reviewed changes

lethemanh force-pushed the implement-summarization-by-ai branch 3 times, most recently from 270e044 to e3cf773 Compare December 4, 2025 04:05

lethemanh requested a review from paultranvan December 4, 2025 04:06

lethemanh force-pushed the implement-summarization-by-ai branch 8 times, most recently from dcfc9aa to 588918a Compare December 4, 2025 08:00

paultranvan reviewed Dec 4, 2025

View reviewed changes

feat: Implement summarization by AI ✨

bcb82c4

BREAKING CHANGE: You need to add react-router-dom >= 6.14.2 as dep in your app ➕

lethemanh force-pushed the implement-summarization-by-ai branch from 588918a to bcb82c4 Compare December 5, 2025 08:13

lethemanh requested a review from paultranvan December 5, 2025 08:13

paultranvan approved these changes Dec 5, 2025

View reviewed changes

feat: Implement summarization by AI ✨ #2866

Are you sure you want to change the base?

feat: Implement summarization by AI ✨ #2866

Uh oh!

Conversation

lethemanh commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Need:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zatteo commented Nov 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zatteo Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paultranvan Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paultranvan Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paultranvan Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lethemanh commented Nov 21, 2025 •

edited

Loading

zatteo Dec 2, 2025 •

edited

Loading

paultranvan Dec 3, 2025 •

edited

Loading

paultranvan Dec 2, 2025 •

edited

Loading

paultranvan Dec 3, 2025 •

edited

Loading