From a22955e72c724fee4588e256e54860a9151dfae5 Mon Sep 17 00:00:00 2001
From: Noam Gal <noam.gal@codefresh.io>
Date: Wed, 17 Dec 2025 12:57:03 +0200
Subject: [PATCH] fix: app-proxy fails to create a Workflow instance (#1008)

Ensure the RoleBinding kind is explicitly set to "RoleBinding"
and the role is set to "Role" for the app-proxy Argo workflows.
This change improves clarity and consistency in the RBAC configuration.
---
 charts/gitops-runtime/templates/app-proxy/workflows-crb.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/charts/gitops-runtime/templates/app-proxy/workflows-crb.yaml b/charts/gitops-runtime/templates/app-proxy/workflows-crb.yaml
index 02b8dc3dc..725f25616 100644
--- a/charts/gitops-runtime/templates/app-proxy/workflows-crb.yaml
+++ b/charts/gitops-runtime/templates/app-proxy/workflows-crb.yaml
@@ -4,12 +4,12 @@
 {{- $_ := set $appProxyContext "Values" (deepCopy (get .Values "app-proxy")) }}
 {{- $_ := set $appProxyContext.Values "global" (deepCopy (get .Values "global")) }}
 apiVersion: rbac.authorization.k8s.io/v1
-kind: {{ $appProxyContext.Values.global.runtime.singleNamespace | ternary "RoleBinding" "ClusterRoleBinding" }}
+kind: RoleBinding
 metadata:
   name: cap-app-proxy-argo-workflows
 roleRef:
   apiGroup: rbac.authorization.k8s.io
-  kind: {{ $appProxyContext.Values.global.runtime.singleNamespace | ternary "Role" "ClusterRole" }}
+  kind: Role
   name: {{ include "codefresh-gitops-runtime.argo-workflows.server.name" . }}
 subjects:
   - kind: ServiceAccount