Touch not working correctly

[QQQQWAS]

When there are more then 2 fingers, HandleButton isn't called sometimes.
my test.c:

#include <rawdraw/os_generic.h>
#include "android_native_app_glue.h"
#include <byteswap.h>
#include <fcntl.h>
#include <stdint.h>
#include <stdio.h>

#include <string.h>

#define CNFG_IMPLEMENTATION
#define CNFG3D

#include <rawdraw/CNFGAndroid.h>
#include <rawdraw/CNFG.h>

void HandleKey(int code, int state){}

struct touch{
	int pos_begin[2];
	int pos[2];
	int down;
};

char console[10000];

typedef struct touch touch;
touch touches[10];
int last_updated;

void HandleButton(int x, int y, int mask, int down){
	touches[mask].pos[0] = x;
	touches[mask].pos[1] = y;
	touches[mask].pos_begin[0] = x;
	touches[mask].pos_begin[1] = y;
	touches[mask].down = down;
	last_updated = mask;
	char out[128];
	sprintf(out, "HandleButton(x: %i, y: %i, mask: %i, bDown: %i)\n", x, y, mask, down);
	strcat(console, out);
}
void HandleMotion(int x, int y, int mask){
	touches[mask].pos[0] = x;
	touches[mask].pos[1] = y;
}

void HandleResume(){}
void HandleSuspend(){}
int HandleDestroy(){return 0;}

int main(int argc, char ** argv){
	CNFGBGColor = 0x002040ff;
	CNFGSetupFullscreen( "Test Bench", 0 );
	while(CNFGHandleInput()){
		CNFGClearFrame();
		CNFGColor( 0xFFFFFFFF );

		for(int i = 0; i < 10; i++){
			char cat[128];
			sprintf(cat, "--%i--\nX: %i\nY: %i\nS: %i\n", last_updated==i ,touches[i].pos[0], touches[i].pos[1], touches[i].down);
			if(touches[i].down){
				CNFGDrawBox(touches[i].pos_begin[0], touches[i].pos_begin[1], touches[i].pos[0], touches[i].pos[1]);
				CNFGPenX = (touches[i].pos_begin[0] + touches[i].pos[0])/2-50;
				CNFGPenY = (touches[i].pos_begin[1] + touches[i].pos[1])/2-60;
				CNFGDrawText(cat, 6);
			}
		}
		CNFGPenX = 0;
		CNFGPenY = 0;

		CNFGDrawText(console, 4);

		CNFGFlushRender();
		CNFGSwapBuffers();
	}
}

video:
https://github.com/user-attachments/assets/2c8089ef-9994-49af-b49e-575f90e99cd2

[cnlohr]

What platform specifically are you testing on? If a modern Android system, you will probably want to adjust the code yourself depending on your needs. I am curious what you come to.

[QQQQWAS]

android 11

[QQQQWAS]

i tried writing my own function:

void process(struct android_app *app, struct android_poll_source *source){
  AInputEvent* event = NULL;
  while (AInputQueue_getEvent(app->inputQueue, &event) >= 0) {
    if (AInputQueue_preDispatchEvent(app->inputQueue, event)) continue;
    int32_t handled = 0;
    if (app->onInputEvent != NULL){
      int type = AInputEvent_getType(event);
      switch (type) {
        case AINPUT_EVENT_TYPE_MOTION:
          int pointer_count = AMotionEvent_getPointerCount(event);

          int32_t action = AMotionEvent_getAction(event);
          int flags = action & AMOTION_EVENT_ACTION_MASK;
          int id = (action & AMOTION_EVENT_ACTION_POINTER_INDEX_MASK) >> AMOTION_EVENT_ACTION_POINTER_INDEX_SHIFT;
          int pid = AMotionEvent_getPointerId(event, id);

          switch(flags){
            case AMOTION_EVENT_ACTION_POINTER_UP:
            case AMOTION_EVENT_ACTION_UP:{
              num_down --;
              touches[pid].down = 0;
              break;
            }
            case AMOTION_EVENT_ACTION_POINTER_DOWN:
            case AMOTION_EVENT_ACTION_DOWN:{
              num_down ++;
              int x = AMotionEvent_getX(event, id);
              int y = AMotionEvent_getY(event, id);
              touches[id].pos[0] = x;
              touches[id].pos[1] = y;
              touches[id].pos_begin[0] = x;
              touches[id].pos_begin[1] = y;
              touches[id].down = 1;
              break;
            }
            case AMOTION_EVENT_ACTION_MOVE:{
              int off = 0; //number of touches preceeding i that are not down
              for(int i = 0; i-off < pointer_count && pid+i<10; i++){
                if(touches[pid+i].down == 0){
                  off++;
                  continue;
                }
                int x = AMotionEvent_getX(event, i-off);
                int y = AMotionEvent_getY(event, i-off);
                touches[pid+i].pos[0] = x; // pid in AMOTION_EVENT_ACTION_MOVE is the first i that is down
                touches[pid+i].pos[1] = y;
              }
              break;
            }
          }
      }
    }
    AInputQueue_finishEvent(app->inputQueue, event, handled);
  }
}

and if i add gapp->inputPollSource.process = process; to main it works

[cnlohr]

Did it work out? If so, would you mind making a PR to rawdrawandroid to improve the default state?

[QQQQWAS]

the issue is in rawdraw, not rawdrawandroid. I modified the function at CNFGEGLDriver.c line 369 to be similar to the one i sent here and it works without other changes

[cnlohr]

Are you willing to make a PR? I would love to integrate this, but I don't know how to identify what is right or wrong with it. So I'd lean on you to do it right.

[QQQQWAS]

i opened a pr

[cnlohr]

Looks pretty close. Please check to make sure you don't overflow the array though.