[WIP] Backend Reorg: Marine Helmet Cleanups#12281
Draft
Nihisohel wants to merge 3 commits into
Draft
Conversation
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
added
the
Merge Conflict
cmss13-ci
Bot
added
Sprites
Contributor
Author
|
Converted to draft since theres still quite a few issues to iron out, and its not even the updated build |
Nihisohel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Suddenly, this is relevant again due to the recent announcement
This is for soomis
Posted early as to deter contribs from planning something like this
Explain why it's good for the game
Helmet files take the most unnecessary amount of file space either from duplicates, or simply because they have a unique looking lobster tail and everyone must look like a snowflake to stand out
This PR cleans up the helmet files by cutting down some of the file bloat, and in turn, converts the distinctive helmet fluff into actual accessories that you can remove if you don't like the look
This also features the ability to customise your helmet strap (hide, leave it hanging, leave it on the brim, or strap it on your neck) and visible helmet cameras, both of which toggled through a verb
Backend-wise, helmets will be properly categorised between their own distinct factions for easier management as well
Testing Photographs and Procedure
Before
After (ignore the CO helmet, this is on an outdated build)
Changelog
🆑
add: Allows the ability to refashion your helmet, from removable lobster tails (and by extension, dust ruffles) to stylish helmet straps, and visible helmet cameras (hiding it is cosmetic)
code: Cleans up and reorganizes the accessory.dm files
code: Cleans up and reorganises helmet files, faction helmets are now pathed differently rather than be from the marine parent for readability
code: The MP cosmetic helmet band is now its own accessory
code: The SL, and by extension, CO front plate is now its own removable accessory
imageadd: Helmet straps are visibly deleted from the helmet DMIs and repurposed into an overlay
imageadd: Helmet cameras are now visible on marine helmets, utilized as an overlay
imagetweak: Deletes a few pixels on the standard squad stripe to accomodate removable lobster tails
imagetweak: Helmet files are slightly cut down save blundir another headache of DMI file reorganization
/:cl: