fixes flaky test fails: radio headset init with wearer value of null#12275
Open
kitchenenthusiast wants to merge 1 commit into
Open
fixes flaky test fails: radio headset init with wearer value of null#12275kitchenenthusiast wants to merge 1 commit into
kitchenenthusiast wants to merge 1 commit into
Conversation
cmss13-ci
Bot
added
Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
(hopefully) fixes the flaky test fails (probably on map init?) for when like, a body spawns but doesn't fully spawn before the minimap subsystem tries to call an update for their minimap icon before the body/wearer is fully init'd. i just made it so no null value returned.
Fixes #12250
Fixes #12237
Fixes #12206
Fixes #12058
silence, bot.
Explain why it's good for the game
ELIMINATE runtimes. this was hitting often-ish enough that i thought it was worth doing since clearly this init pattern happens...kind of often. reduces runtime issues by standardizing for whenever anyone edits roles, adds roles, or adds new maps (with prop corpses).
i don't know what the exact server times translate to with regards to actual round times, so my best guess is what i said above, it's a null value on partially-appended inventory items when prop bodies are spawning in on map load. in the event this intersects with survs/shipside staff that spawn with headsets, the next signal update (movement, taking damage) would pull a minimap icon update anyways, so i don't think it will cause issues there!
Testing Photographs and Procedure
very hard to test since flaky. server starts okay and minimap icons for ded bodies appear :)
Changelog
🆑
fix: Fixes runtime during map initialization caused by minimap subsystem calling icon updates before mobs are fully initialized
/:cl: