Skip to content

Leadership Changes: Megaphone Additions#11541

Merged
MistChristmas merged 22 commits into
cmss13-devs:masterfrom
Nihisohel:megaphone-man
May 24, 2026
Merged

Leadership Changes: Megaphone Additions#11541
MistChristmas merged 22 commits into
cmss13-devs:masterfrom
Nihisohel:megaphone-man

Conversation

@Nihisohel
Copy link
Copy Markdown
Contributor

@Nihisohel Nihisohel commented Jan 16, 2026

About the pull request

Part 5, awesome
Allows auto-amplification of your text through a unique action toggle, increasing your range and text size

Explain why it's good for the game

I've see a lot of officers and even SLs (fucking annoying honestly) bring the megaphone out in the field and take their time to type a message for everyone within their range to hear and see, which is honestly way worse than it really is due to the cooldown and the fact that speaking normally is just way better to begin with.

This PR buffs megaphone use by introducing another mechanic through unique action which amplifies the voice of the speaker similar to using it normally, but also increases the range for any listeners to one screens worth
That said, its possibly a tentative value, since it may be pretty strong

Additionally, megaphone broadcasts, when used by leaders, now inflicts the "hushed" status effect, which forces listener speech to a whisper for a good bit unless you are a hostile/neutral faction, possess leadership skills, or assigned as a squad leader

A bit depressing that it came to the point that people could not simply shut the fuck up that we have to mechanically enforce silence with megaphones

Also includes a lot of other fixes which I cannot be arsed to document here, refer to the changelog

closes #10083

Testing Photographs and Procedure

DISCLAIMER: Theres probably some changes in the videos versus the final product but the overall intent is there

speaking demo
https://youtu.be/cJlORIlL98w

hushed status effect demo
https://youtu.be/hnPs5JpulZw

"From afar" message
image

Changelog

🆑 Nihisohel, Sponge in discord for HUD sprites
add: Megaphones can now be used as an amplifier, allowing loud text by talking normally as long as it is toggled on via unique_action and only when spoken when it is on the active hand
balance: Megaphones, when amplified, increases its listener range by a screens worth, ensuring that people can hear you from farther away
add: Introduces the "hushed" status effect, which forces whisper on inflicted mobs.
add: Megaphone broadcasting (the original method of use) now inflicts hushed on non-leader humans
balance: Megaphone hushing lasts for approximately 3 seconds, which should be more than enough for the next broadcast, probably
balance: Megaphone broadcast cooldown is reduced from 2 seconds to 1.5 seconds
balance: Megaphones are no longer a universal translator
balance: Hostile and neutral factions don't really care about what you are broadcasting and would not get hushed by your speech
fix: Megaphone broadcasting now shows your rank
code: Langchat_speech now supports language scrambling
code: Megaphones now respect the color of the language when broadcasting
code: Megaphones can now auto_punctuate
code: The show_message proc now support chat_filters, undefined by default
refactor: Deprecates langchat_long_speech and folds it into langchat_speech
fix: Fixes the notification when attempting to use a megaphone while player muted, it was fetching the megaphone rather than the user for some reason
fix: Fixes being able to open multiple windows of the tgui_input_text proc, which is used by a LOT of things, including the megaphone.
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog Jan 16, 2026
@cmss13-ci cmss13-ci Bot added Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more Code Improvement Make the code longer Refactor Make the code harder to read size/L Denotes a PR that changes 200-799 lines, ignoring generated files. labels Jan 16, 2026
@Nihisohel
Copy link
Copy Markdown
Contributor Author

if someone wants to code auto punctuation into the broadcast function, be my guest, i have touched this goddamn file enough

@MistChristmas
Copy link
Copy Markdown
Contributor

As already said in Discord. Just handle language prefixes being in the message, and then this should be TM ready.

Comment thread code/game/objects/items/devices/megaphone.dm Outdated
Comment thread code/game/objects/items/devices/megaphone.dm Outdated
Comment thread code/game/objects/items/devices/megaphone.dm Outdated
Comment thread code/game/objects/items/devices/megaphone.dm Outdated
Comment thread code/game/objects/items/devices/megaphone.dm Outdated
Comment thread code/game/objects/items/devices/megaphone.dm Outdated
Comment thread code/game/objects/items/devices/megaphone.dm Outdated
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Changes Requested in Review Backlog Jan 21, 2026
@cm13-github
Copy link
Copy Markdown
Contributor

cm13-github commented Jan 21, 2026

Test merge deployment history:

Test Merge Deployed @ 01/21/2026 23:05:47 +00:00:
Server Instance

CM13 Live

Revision

Origin: 8305b47
Pull Request: 8688c9e
Server: 9d63d2d

Test Merge Removed @ 01/22/2026 01:07:03 +00:00:
Server Instance

CM13 Live

Test Merge Deployed @ 01/23/2026 05:52:48 +00:00:
Server Instance

CM13 Live

Revision

Origin: 86d5301
Pull Request: 076576e
Server: 5f699f6

Test Merge Updated @ 01/23/2026 08:13:17 +00:00:
Server Instance

CM13 Live

Revision

Origin: 86d5301
Pull Request: 076576e
Server: 48c374a

Test Merge Updated @ 01/24/2026 00:28:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 8aa543a
Pull Request: 076576e
Server: 2914db3067e631b3e4728e1cc6ccb9cdc40aa855

Test Merge Updated @ 01/24/2026 00:59:12 +00:00:
Server Instance

CM13 Live

Revision

Origin: 210cb26
Pull Request: 076576e
Server: 6d14ca7273fff49c2ed86592d631919691461598

Test Merge Updated @ 01/24/2026 02:00:13 +00:00:
Server Instance

CM13 Live

Revision

Origin: cd1a642
Pull Request: 076576e
Server: 466b6102f3a14b4a8fbcaf8f4ff4624c334bc8d7

Test Merge Updated @ 01/24/2026 09:32:45 +00:00:
Server Instance

CM13 Live

Revision

Origin: 9443162
Pull Request: 076576e
Server: 9816a33de65e9532b0cabe2f132e9480dff1e643

Test Merge Updated @ 01/25/2026 06:08:14 +00:00:
Server Instance

CM13 Live

Revision

Origin: 9443162
Pull Request: 076576e
Server: 1a3c750

Test Merge Updated @ 01/25/2026 09:39:52 +00:00:
Server Instance

CM13 Live

Revision

Origin: 5efc484
Pull Request: 076576e
Server: c983c8390f56fcf77493dec29a037a02d84d3771

Test Merge Updated @ 01/25/2026 12:41:22 +00:00:
Server Instance

CM13 Live

Revision

Origin: 5efc484
Pull Request: 076576e
Server: 124a485

Test Merge Updated @ 01/25/2026 14:12:51 +00:00:
Server Instance

CM13 Live

Revision

Origin: 5efc484
Pull Request: 076576e
Server: 47f7538

Test Merge Updated @ 01/25/2026 17:58:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 5efc484
Pull Request: 076576e
Server: 2923644

Test Merge Removed @ 01/26/2026 00:16:33 +00:00:
Server Instance

CM13 Live

Test Merge Deployed @ 05/23/2026 04:51:36 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4412c87
Pull Request: 423f0ab
Server: 27cfb8a

Test Merge Updated @ 05/23/2026 16:14:49 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4412c87
Pull Request: 4d43ecf
Server: 3156670

Test Merge Updated @ 05/23/2026 16:25:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 3d558ec
Pull Request: 4d43ecf
Server: f9f92f73e48de6d52d3be8c3efda2f16b4ec271b

Test Merge Updated @ 05/23/2026 16:54:29 +00:00:
Server Instance

CM13 Live

Revision

Origin: 3d558ec
Pull Request: 4d43ecf
Server: 1107c0538fa970ab344b805080dede1e0cb50114

Test Merge Updated @ 05/23/2026 23:57:15 +00:00:
Server Instance

CM13 Live

Revision

Origin: a7e8c2a
Pull Request: 4d43ecf
Server: f3dd2ce

Test Merge Updated @ 05/24/2026 00:27:19 +00:00:
Server Instance

CM13 Live

Revision

Origin: b8fcfd6
Pull Request: 4d43ecf
Server: a369ff9

Test Merge Updated @ 05/24/2026 02:28:27 +00:00:
Server Instance

CM13 Live

Revision

Origin: b8fcfd6
Pull Request: 4d43ecf
Server: c6143156b0b0ecd8ca9138420175cce2034dcece

Test Merge Updated @ 05/24/2026 04:29:29 +00:00:
Server Instance

CM13 Live

Revision

Origin: bdde9e6
Pull Request: 4d43ecf
Server: 9780bf869a152e3fb1e408c6b2941338cceaad88

Test Merge Updated @ 05/24/2026 13:01:51 +00:00:
Server Instance

CM13 Live

Revision

Origin: 1318bb3
Pull Request: 4d43ecf
Server: f8c16090ef4be58b615df6da75175fe27e9e6e97

Test Merge Updated @ 05/24/2026 13:32:38 +00:00:
Server Instance

CM13 Live

Revision

Origin: ec4a93d
Pull Request: 4d43ecf
Server: 84a90231526ec88e16ab712a326968194d472d61

Test Merge Removed @ 05/24/2026 15:25:21 +00:00:
Server Instance

CM13 Live

@cm13-github
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cmss13-ci cmss13-ci Bot added the Sprites Remove the soul from the game. label May 22, 2026
@Nihisohel
Copy link
Copy Markdown
Contributor Author

bro come on

Nihisohel added 3 commits May 22, 2026 12:19
This reverts commit a1717fa.
This reverts commit ba5e8ca.
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label May 22, 2026
@cm13-github
Copy link
Copy Markdown
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@despong
Copy link
Copy Markdown

despong commented May 23, 2026

576e5dc1-ec94-4cd5-9ae4-5edb2e0139c0

@Locardoc
Copy link
Copy Markdown

Please make the command personnel and MP exempt from the hush ability. They certainly need to be able to speak loud when it comes to giving our clear orders to stop certain wrongdoings, and Commanders shouldn't be silenced at all.

@Blundir Blundir added the Sprites Approved confirmed no stray pixels label May 23, 2026
@Nihisohel
Copy link
Copy Markdown
Contributor Author

Please make the command personnel and MP exempt from the hush ability. They certainly need to be able to speak loud when it comes to giving our clear orders to stop certain wrongdoings, and Commanders shouldn't be silenced at all.

Anyone with leadership skill does not get affected by the hush,

As for MPs, no, get the CMP to do it

@Nihisohel Nihisohel marked this pull request as draft May 24, 2026 01:55
@Nihisohel Nihisohel marked this pull request as ready for review May 24, 2026 02:45
@github-project-automation github-project-automation Bot moved this from Changes Requested to Partially Approved / Mergeable in Review Backlog May 24, 2026
@MistChristmas MistChristmas added this pull request to the merge queue May 24, 2026
Merged via the queue into cmss13-devs:master with commit 4f1da89 May 24, 2026
29 of 30 checks passed
@github-project-automation github-project-automation Bot moved this from Partially Approved / Mergeable to Merged in Review Backlog May 24, 2026
cmss13-ci Bot added a commit that referenced this pull request May 24, 2026
@Nihisohel Nihisohel deleted the megaphone-man branch May 24, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge Fix Fix one bug, make ten more Refactor Make the code harder to read size/L Denotes a PR that changes 200-799 lines, ignoring generated files. Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

Megaphone Ignores Languages and Displays Text in English in Chatbox

6 participants