Repository navigation
qlog-dancer: escape log-derived text in HTML reports - #2811
Open
uchiha-bug-hunter wants to merge 1 commit into
Open
uchiha-bug-hunter wants to merge 1 commit into
uchiha-bug-hunter wants to merge 1 commit into
Conversation
ghedo
added
type: bugfix
Author
|
gentle ping |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unescaped log text in the report tables
table_to_htmlwrites cell content out verbatim, and every cell comes from the log being analysed, so a string in the file reaches the output as live markup: an sqlog event namedtransport:<img src=x onerror=alert(1)>lands as an element in the generatedevent-list.html, andevent_list_html_from_sqlogis also the string the wasm UI passes toset_inner_html. Escaping now happens where the rows are turned into anHtmlTable, which covers the overview, closures, requests and event-list tables plus the session heading inrequests(), and the committed test fails without it.