Skip to content

Commit 1cee533

Browse files
committed
copy binary dedup header values before storing in cache
1 parent 3fd2ede commit 1cee533

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

lib/rabbitmq_message_deduplication/common.ex

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,14 @@ defmodule RabbitMQMessageDeduplication.Common do
7575
cache = cache_name(name)
7676

7777
case message_header(message, "x-deduplication-header") do
78-
key when not is_nil(key) -> case Cache.insert(cache, key, ttl) do
79-
{:ok, :exists} -> true
80-
{:ok, :inserted} -> false
81-
end
78+
key when not is_nil(key) ->
79+
# the key header value might reference a larger binary of the
80+
# original raw AMQP frame
81+
key = if is_binary(key) do :binary.copy(key) else key end
82+
case Cache.insert(cache, key, ttl) do
83+
{:ok, :exists} -> true
84+
{:ok, :inserted} -> false
85+
end
8286
nil -> false
8387
end
8488
end

0 commit comments

Comments
 (0)