fix(persist-pre-commit-cache): skip backup when cache is mount point

Author: ckagerer

src/persist-pre-commit-cache/install.sh

@@ -26,27 +26,48 @@ tee "$INIT_SCRIPT_PATH" >/dev/null <<'EOF'
 set -e
 set -x
 
+# Check if a path is a mount point
+is_mount_point() {
+  if command -v mountpoint >/dev/null 2>&1; then
+    mountpoint -q "$1"
+  else
+    # Fallback for systems without mountpoint command
+    mount | grep -q " on $(readlink -f "$1") "
+  fi
+  return $?
+}
+
 # Handle existing ~/.cache/pre-commit directory
 if [ -d ~/.cache/pre-commit ] && [ ! -L ~/.cache/pre-commit ]; then
-  echo "Backing up existing ~/.cache/pre-commit to ~/.cache/pre-commit.bak"
-  mv ~/.cache/pre-commit ~/.cache/pre-commit.bak
+  # Check if it's already a mount point (e.g., from another devcontainer feature)
+  if is_mount_point ~/.cache/pre-commit 2>/dev/null; then
+    echo "Note: ~/.cache/pre-commit is already mounted by another feature, skipping backup"
+  else
+    echo "Backing up existing ~/.cache/pre-commit to ~/.cache/pre-commit.bak"
+    mv ~/.cache/pre-commit ~/.cache/pre-commit.bak
+  fi
 fi
 
 # Create symlink for pre-commit cache if it doesn't already exist
-if [ ! -L ~/.cache/pre-commit ]; then
+if [ ! -L ~/.cache/pre-commit ] && [ ! -d ~/.cache/pre-commit ]; then
   mkdir -p ~/.cache
   ln -s /.persist-precommit-cache ~/.cache/pre-commit
   echo "Created symlink: ~/.cache/pre-commit -> /.persist-precommit-cache"
 fi
 
 # Handle existing ~/.cache/prek directory
 if [ -d ~/.cache/prek ] && [ ! -L ~/.cache/prek ]; then
-  echo "Backing up existing ~/.cache/prek to ~/.cache/prek.bak"
-  mv ~/.cache/prek ~/.cache/prek.bak
+  # Check if it's already a mount point
+  if is_mount_point ~/.cache/prek 2>/dev/null; then
+    echo "Note: ~/.cache/prek is already mounted by another feature, skipping backup"
+  else
+    echo "Backing up existing ~/.cache/prek to ~/.cache/prek.bak"
+    mv ~/.cache/prek ~/.cache/prek.bak
+  fi
 fi
 
 # Create symlink for prek cache if it doesn't already exist
-if [ ! -L ~/.cache/prek ]; then
+if [ ! -L ~/.cache/prek ] && [ ! -d ~/.cache/prek ]; then
   mkdir -p ~/.cache
   ln -s /.persist-prek-cache ~/.cache/prek
   echo "Created symlink: ~/.cache/prek -> /.persist-prek-cache"