Skip to content

Peer review to address #1

Description

@chasingmaxwell

curious about why the superfluous index.js files

  • See if serverless.yml will accept a more streamlined structure.

Would suggest adding jsdoc blocks

  • Add jsdoc blocks

Given that you’re using latest in babel, you can do more es6 things. https://github.com/chasingmaxwell/FeedBoost/blob/master/src/lib/token/index.js#L15 can just be {code}

  • Use shorthand in places where the key and name of the variable for the value are the same in objects.

https://github.com/chasingmaxwell/FeedBoost/blob/master/src/lib/token/index.js#L7 no need to allocate a variable for immediate return

  • Simplify by returning the result of the function invocation rather than creating a variable.

I would consider getting [a request promise library] where you can instantiate with values that won’t change, like a base url.

  • Evaluate the use of request-promise.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions